Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341211

Summary: [reconciler] Linked extension location becomes invalid when a bundle's plugin.xml is removed while keeping its directory
Product: [Eclipse Project] Equinox Reporter: Martin Oberhuber <mober.at+eclipse>
Component: p2Assignee: P2 Inbox <equinox.p2-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: akurtakov, john.arthorne, overholt, pascal, saispo, sflaniga, simon_kaegi
Version: 3.5.2   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard: stalebug
Attachments:
Description Flags
Logfile showing bundle exceptions none

Description Martin Oberhuber CLA 2011-03-29 07:15:35 EDT 
CQ:WIND00263363
Build ID: Eclipse 3.5.2 on Windows XP

When an existing old-style bundle in an extension location becomes invalid by deleting its plugin.xml file (while still keeping its directory around), bad things happen to the profile - it looks like some exception invalidates other bundles too.

Steps to reproduce:
1. Unzip Eclipse 3.5.2 into C:\Eclipse
2. touch C:\ext\eclipse\.eclipseextension
3. extract some working software/bundles into C:\ext\eclipse\plugins
4. touch C:\ext\eclipse\plugins\foo.bundle\foo
5. create proper C:\ext\eclipse\plugins\foo.bundle\plugin.xml
6. create C:\Eclipse\eclipse\dropins\foo.link pointing to C:\ext\eclipse

7. Launch Eclipse. Verify that foo.bundle is picked up (note that it's an
   old-style bundle without META-INF/MANIFEST.MF).

8. delete C:\ext\eclipse\foo.bundle\plugin.xml

--> Launch eclipse : related bundles in the extension location are invalidated.

This might be related to bug #251167 which also talks about repeated install / uninstall operations in an extension location. While we acknowledge that just deleting the plugin.xml file is "not clean", it does seem to expose some behavior in p2 that is problematic: 

  (a) The error doesn't affect the bad bundle only, but other bundles too
  (b) Behavior is not symmetric: Initially detecting a directory without
      plugin.xml is simply ignored, but deleting the plugin.xml after the
      fact leads to bad behavior.
Comment 1 Martin Oberhuber CLA 2011-03-29 09:29:48 EDT 
Created attachment 192087 [details]
Logfile showing bundle exceptions

Attached logfile the exceptions occuring. 

The com.windriver.ide.doc.wr_tilcon is in this case the degenerate bundle that was deprived of its plugin.xml (and never had a MANIFEST.MF).

Again I'd find it very acceptable to skip the degenerate bundle, but I think it's a problem that the entire extension location gets into a weird state.
Comment 2 Eclipse Genie CLA 2019-06-18 20:17:34 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.