Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341144

Summary: Stack renderer does not honor the TBR state of its Toolbar / Menus
Product: [Eclipse Project] e4 Reporter: Eric Moffatt <emoffatt>
Component: UIAssignee: Project Inbox <e4.ui-inbox>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: pwebster
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: stalebug
Attachments:
Description Flags
Patch to check the TBR state during rendering of the tab none

Description Eric Moffatt CLA 2011-03-28 13:42:02 EDT
The current code does not check the 'toBeRendered' value when deciding to render the parts 'embedded' toolbar / menu.
Comment 1 Eric Moffatt CLA 2011-03-28 13:47:35 EDT
Created attachment 192030 [details]
Patch to check the TBR state during rendering of the tab
Comment 2 Eric Moffatt CLA 2011-03-28 13:48:25 EDT
Committed in >20110328. Applied the patch.
Comment 3 Eric Moffatt CLA 2011-03-28 13:49:29 EDT
For completeness we should now listen for the state changing and re-show the tab if the TBR state changes....
Comment 4 Paul Webster CLA 2011-03-28 13:53:52 EDT
We probably need the check in ToolBarManagerRenderer, that's where we create the dropdown menu tag.

PW
Comment 5 Paul Webster CLA 2011-05-13 15:23:32 EDT
(In reply to comment #4)
> We probably need the check in ToolBarManagerRenderer, that's where we create
> the dropdown menu tag.

This is now done in the Lazy/StackRenderer combo.

PW
Comment 6 Dani Megert CLA 2013-06-05 10:57:08 EDT
Removing outdated target milestone.
Comment 7 Eclipse Genie CLA 2018-09-21 16:37:13 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 8 Lars Vogel CLA 2019-06-05 07:37:17 EDT
This is a mass change to close all e4 bugs marked with "stalebug" whiteboard.

If this bug is still valid, please reopen and remove the "stalebug" keyword.