Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341126

Summary:	Make RegionLifecycleListener an internal detail.
Product:	[RT] Virgo	Reporter:	Thomas Watson <tjwatson>
Component:	runtime	Assignee:	Glyn Normington <glyn.normington>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	glyn.normington
Version:	3.0.0.M03	Flags:	glyn.normington: iplog+
Target Milestone:	3.0.0.M04
Hardware:	All
OS:	All
Whiteboard:

Description Thomas Watson

2011-03-28 12:01:59 EDT

Currently the RegionLifecycleListener is an implementation detail for the region digraph mbeans.  The listener is rather limited and may need enhancement if others want to use it.  Rather than trying to anticipate what is needed by others in the future it may be better to make the RegionLifecycleListner an internal detail that is not exposed as API.

This way we are free to add a listener mechanism later if we have a scenario that needs it.

I have provided a fix for this in a github repo.  I will provide details in a separate comment.

Comment 1 Glyn Normington

2011-03-28 12:18:32 EDT

Thanks for the contribution Tom!

Comment 2 Thomas Watson

2011-03-28 12:26:13 EDT

I have done the work to make RegionLifecycleListener an internal detail using the githug repo:

https://github.com/tjwatson/regions.listeners

The following commits from https://github.com/tjwatson/regions.listeners:
 
git rev-list 7adebc4b7cfa6025fc1fceca752bafb9b8e38c9f ^bfce058527331aff06b05a6ea26b44ec6ba276cb

This should include the following commit records.

https://github.com/tjwatson/regions.listeners/commit/7adebc4b7cfa6025fc1fceca752bafb9b8e38c9f
https://github.com/tjwatson/regions.listeners/commit/8d9dd63ca54891098925248c1bae3392f699e38c
https://github.com/tjwatson/regions.listeners/commit/b76304142c00dfa3940e9548fd142c890b92f1c4
https://github.com/tjwatson/regions.listeners/commit/b0c444404a80cf38897db0c7026c48242388bf71
https://github.com/tjwatson/regions.listeners/commit/aecc54d158ba82444a0cabef3576aff99bc353db
https://github.com/tjwatson/regions.listeners/commit/82b06832e993beaf1971c377f429f2245d04e0ee

I confirm the following:

- I authored 100% of the code
- I have my employer's permission to contribute the code to eclipse
- The new files have a suitable license header

Comment 3 Thomas Watson

2011-03-28 12:28:22 EDT

> The following commits from https://github.com/tjwatson/regions.listeners:
> 
> git rev-list 7adebc4b7cfa6025fc1fceca752bafb9b8e38c9f
> ^bfce058527331aff06b05a6ea26b44ec6ba276cb

That should be:

git rev-list 82b06832e993beaf1971c377f429f2245d04e0ee ^bfce058527331aff06b05a6ea26b44ec6ba276cb

Comment 4 Glyn Normington

2011-03-28 12:36:33 EDT

Pushed to:

ssh://gnormington@git.eclipse.org/gitroot/virgo/org.eclipse.virgo.kernel.git

as git rev-list d9203b6ce1b49bf37b4881023183bde9ef01b8a2 ^bfce058527331aff06b05a6ea26b44ec6ba276cb:

d9203b6ce1b49bf37b4881023183bde9ef01b8a2
cdfb3b9a659adce3fbcce72a387b4c049b09b943
ca2891b974b4c90bd3e0dff7ec5bada0444d7e25
2d5214e1ca50e27ea3453b78785aeae321fe1f69
8635a443142c68ddb42ef64bad94eccb2b03c566
3659e02bc62e6cc0a5d20d8eb6b55ce7ef7c9edf