Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341121

Summary: [ui] ResolutionResultsWizardPage resolves on UI thread
Product: [Eclipse Project] Equinox Reporter: Matthew Piggott <matthew>
Component: p2Assignee: Matthew Piggott <matthew>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: pascal, susan
Version: 3.7   
Target Milestone: 3.7 RC1   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 340356    
Attachments:
Description Flags
Move resolution to wizard context
none
Resolve on wizard context
none
Improved patch for ResolutionResultsWizardPage pascal: review+

Description Matthew Piggott CLA 2011-03-28 11:38:15 EDT
Created attachment 192014 [details]
Move resolution to wizard context

If a ResolutionResultsWizardPage (base class used in all the install wizards) is opened with an unresolved operation the resolution is performed in the constructor on the UI thread.  To avoid locking the UI at the end of createControl() I've added a runnable which performs the resolution in a runnable.

Does anyone see a problem with the patch?
Comment 1 Matthew Piggott CLA 2011-04-07 15:16:50 EDT
Created attachment 192774 [details]
Resolve on wizard context
Comment 2 Matthew Piggott CLA 2011-04-08 10:57:11 EDT
Susan if you get the chance would you mind taking a look at this?
Comment 3 Matthew Piggott CLA 2011-04-08 10:58:04 EDT
The patch I've attached that is.
Comment 4 Matthew Piggott CLA 2011-05-11 10:17:41 EDT
Created attachment 195354 [details]
Improved patch for ResolutionResultsWizardPage
Comment 5 Pascal Rapicault CLA 2011-05-11 11:06:42 EDT
Comment on attachment 195354 [details]
Improved patch for ResolutionResultsWizardPage

Patch committed.
Comment 6 Pascal Rapicault CLA 2011-05-11 11:07:42 EDT
.