Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341102

Summary:

Wrong license text for SDK

Product:

[Eclipse Project] Platform

Reporter:

John Arthorne <john.arthorne>

Component:

Releng

Assignee:

Kim Moir <kim.moir>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

aniefer, kim.moir

Version:

4.1

Target Milestone:

4.1 M7

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Screen shot	none
patch for e4.rcp feature	none
patch for 3.7 builder's product files	none

Description John Arthorne

2011-03-28 09:26:56 EDT

Build: I20110322

When upgrading to this build, I was presented with two different copies of the Eclipse SUA. It looks like the SDK feature has the old license text.

Comment 1 John Arthorne

2011-03-28 09:27:23 EDT

Created attachment 192001 [details]
Screen shot

Comment 2 Kim Moir

2011-03-29 18:06:40 EDT

The features with the old license are 
org.eclipse.e4.rcp and org.eclipse.e4.rcp.source

I'll attach a patch for those

I also noticed that emf.common and emf.core also have the old license.

Comment 3 Kim Moir

2011-03-29 19:36:39 EDT

Created attachment 192150 [details]
patch for e4.rcp feature

Comment 4 Kim Moir

2011-03-29 19:52:41 EDT

Andrew, do you want to review this patch or should I just release it?

Comment 5 Andrew Niefer

2011-03-30 12:11:06 EDT

Kim,
It looks like the org.eclipse.e4.rcp feature actually needs to be updated to use the shared licensing stuff.

I think John is seeing a seperate issue, there is a license in org.eclipse.releng.eclipsebuilder/eclipse/buildConfigs/sdk/builder/sdk.product
 and the other .product files, and this is what he is seeing in the screenshot.  This affects both 3.7 and 4.1

Comment 6 Kim Moir

2011-03-31 07:25:48 EDT

Thanks Andrew, I'll attach patches for the builder for these issues.

Comment 7 Kim Moir

2011-04-08 15:13:21 EDT

Created attachment 192873 [details]
patch for 3.7 builder's product files

Comment 8 Kim Moir

2011-04-12 14:26:53 EDT

I verified this fix in the 3.7 stream. Released the same patch into the 4.1 stream builder.  Also,I released and tagged the e4.rcp feature so it would used shared licenses.

Comment 9 Kim Moir

2011-04-18 13:37:20 EDT

verified in 4.1 stream build I20110415-1030 as well.