Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341089

Summary:

Codan does not handle missing functions in macros correctly

Product:

[Tools] CDT

Reporter:

Thomas Kallenberg <thomas>

Component:

cdt-codan

Assignee:

Emanuel Graf <emanuel>

Status:

RESOLVED FIXED

QA Contact:

Elena Laskavaia <elaskavaia.cdt>

Severity:

normal

Priority:

CC:

cdtdoug, emanuel, mschwab

Version:

8.0

Target Milestone:

8.0

Hardware:

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch to support correct reporting of missing functions in macro	none
Patch for clean marker message in case of macros	emanuel: iplog+

Description Thomas Kallenberg

2011-03-28 08:18:57 EDT

Created attachment 191996 [details]
patch to support correct reporting of missing functions in macro

Hi, 

Codan does not return the correct name and position of a missing function, if the call is made from a macro like:

#define MACRO(f) f()

int function()
{
 MACRO(doesnotexist());
}

Codan would report the whole line as a problem. However, the correct information is needed to create a non existing function.

Thank you very much for looking into this.

cheers, Thomas

Comment 1 Martin Schwab

2011-04-05 11:31:44 EDT

Created attachment 192569 [details]
Patch for clean marker message in case of macros

We've cleaned up the patch, made it work with current HEAD, tested it with Codan's AutomatedIntegrationSuite

Premium advantages:
* add only 7 lines of code to your code base
* These 7 lines are compensated with 10 lines of tests
* You can only win if you have a look at this patch :-)

Comment 2 CDT Genie

2011-04-06 04:23:05 EDT

*** cdt cvs genie on behalf of egraf ***
Bug 341089: Codan does not handle missing functions in macros correctly
<a  href=https://bugs.eclipse.org/bugs/show_bug.cgi?id=341089>https://bugs.eclipse.org/bugs/show_bug.cgi?id=341089</a>

[*] ProblemBindingCheckerTest.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/internal/checkers/ProblemBindingCheckerTest.java?root=Tools_Project&r1=1.2&r2=1.3

[*] ProblemBindingChecker.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/ProblemBindingChecker.java?root=Tools_Project&r1=1.8&r2=1.9

[*] AbstractIndexAstChecker.java 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core.cxx/src/org/eclipse/cdt/codan/core/cxx/model/AbstractIndexAstChecker.java?root=Tools_Project&r1=1.16&r2=1.17

Comment 3 Emanuel Graf

2011-04-06 04:33:08 EDT

Fixed in HEAD >20110406