| Summary: | Remove workaround for AspectJ bug | ||
|---|---|---|---|
| Product: | [RT] Virgo | Reporter: | Glyn Normington <glyn.normington> |
| Component: | runtime | Assignee: | daniel marthaler <dmarthaler> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | dmarthaler, eclipse, fwaibel |
| Version: | unspecified | Keywords: | helpwanted |
| Target Milestone: | 3.7.0.M04 | ||
| Hardware: | PC | ||
| OS: | Mac OS X - Carbon (unsup.) | ||
| Whiteboard: | |||
| Bug Depends on: | 292239 | ||
| Bug Blocks: | |||
Need to upgrade AspectJ to pick up this fix. We are now on AspectJ 1.6.12 and the Bug mentioned below has been fixed. Thanks for spotting this. We are free to try the tidy up suggested in the description. LGTM. Thanks Dani for fixing this. |
The ExceptionCleaner aspect in util currently checks for Throwable: after(Object o) throwing(Throwable t) : exposedViaJmx(o) { if (t instanceof Exception) { .... } } Once bug 292239 is fixed in AspectJ, this can be changed to"throwing(Exception)" and the instanceof check can be deleted.