Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341027

Summary: [build] changesets should provide right file icon
Product: z_Archived Reporter: Benjamin Muskalla <b.muskalla>
Component: MylynAssignee: Benjamin Muskalla <b.muskalla>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: steffen.pingel
Version: unspecified   
Target Milestone: 0.9   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on: 350333    
Bug Blocks:    
Attachments:
Description Flags
patch
none
mylyn/context/zip
none
patch
none
patch (commons)
none
mylyn/context/zip
none
patch (builds)
none
patch (tasks)
none
patch (builds)
none
mylyn/context/zip none

Description Benjamin Muskalla CLA 2011-03-26 01:57:59 EDT 
The files in the changes section should show the corresponding icons for the file.
Comment 1 Benjamin Muskalla CLA 2011-03-26 02:01:16 EDT 
Created attachment 191950 [details]
patch

.
Comment 2 Benjamin Muskalla CLA 2011-03-26 02:01:18 EDT 
Created attachment 191951 [details]
mylyn/context/zip
Comment 3 Benjamin Muskalla CLA 2011-03-26 03:16:49 EDT 
Created attachment 191952 [details]
patch

First one was broken
Comment 4 Steffen Pingel CLA 2011-03-26 23:54:59 EDT 
Looks good. We have similar code in AttachmentTableLabelProvider. Would be nice to generalize this in the commons.
Comment 5 Benjamin Muskalla CLA 2011-07-14 19:23:09 EDT 
Created attachment 199720 [details]
patch (commons)

Steffen, here is a patch for commons.

Wondered about two things:
* While CommonImages feels the right class, it doesn't align to the rest of the class. Maybe move this to CommonUiUtil?

* Adapted the idea to have a common image for "image files" as we do in the AttachmentTableLabelProvider
Comment 6 Benjamin Muskalla CLA 2011-07-14 19:23:11 EDT 
Created attachment 199721 [details]
mylyn/context/zip
Comment 7 Benjamin Muskalla CLA 2011-07-14 19:24:35 EDT 
Created attachment 199722 [details]
patch (builds)

.
Comment 8 Benjamin Muskalla CLA 2011-07-14 19:25:27 EDT 
Created attachment 199723 [details]
patch (tasks)

.
Comment 9 Benjamin Muskalla CLA 2011-07-14 19:44:49 EDT 
Created attachment 199724 [details]
patch (builds)

Also use it in the artifacts section.
Comment 10 Steffen Pingel CLA 2011-07-15 19:13:03 EDT 
Thanks Benjamin. I have applied the changes based on the work for bug 350333.
Comment 11 Steffen Pingel CLA 2011-07-15 19:13:05 EDT 
Created attachment 199777 [details]
mylyn/context/zip