Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341009

Summary:

Can't drag Outline view back to its original position.

Product:

[Eclipse Project] e4

Reporter:

Eugene Ostroukhov <eostroukhov>

Component:

Assignee:

Project Inbox <e4.ui-inbox>

Status:

RESOLVED FIXED

QA Contact:

Eric Moffatt <emoffatt>

Severity:

normal

Priority:

Version:

unspecified

Target Milestone:

4.1 RC1

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Patch to allow dragging out of the shared area	none
Handle putting views outside the perspective	none
Patch to enable 'one tab == stack' DnD	none

Description Eugene Ostroukhov

2011-03-25 17:24:32 EDT

1. Run E4 SDK and open Java perspective. Note that Outline is to the right from the editor area.
2. Drag Outline elsewhere in the perspective (i.e. put it to the right of the editor but into the editor area).
3. Try to put outline back to the right of the editor area (it is, in a separate stack outside of editor area).

E4 will not let you put the Outline there.

Comment 1 Eric Moffatt

2011-04-14 10:16:51 EDT

Eugene, this is indeed a serious issue. We talked about this at the EclipseCon BOF and the basic problem is that we currently have no way to distinguish when you are splitting a stack in the 'shared area' whether the resulting stack should be inside the area or outside it.

One approach *might* be to force the user to drag the part into the area first and then split it. The logic would be that if you split the area the result is determined by whether the part was originally inside or outside the area...

If you have any input now's the time...;-).

Comment 2 Eric Moffatt

2011-05-09 16:10:21 EDT

Created attachment 195138 [details]
Patch to allow dragging out of the shared area


This is much better but still needs a bit of polish...for example eliminating DnD operations that end up being NO-OPs (i.e. splitting a stack with itself...) as well as ensuring that we also handle (or wire off) the case of dragging a stack outside the perspective.

I'll be taking a polish pass at the before RC1 is done. One of the general rules driving the design is to not create stacks if we can avoid it. This means that dragging the only visible element in a stack == dragging the stack (meaning its placeholders also move).

This will require that we modify the StackDropTarget to allow dropping stacks...

Comment 3 Eric Moffatt

2011-05-09 16:12:29 EDT

Committed in >20110509. Applied the patch.

Comment 4 Eric Moffatt

2011-05-10 09:20:34 EDT

Created attachment 195210 [details]
Handle putting views outside the perspective

Comment 5 Eric Moffatt

2011-05-12 15:07:44 EDT

Created attachment 195530 [details]
Patch to enable 'one tab == stack' DnD


This is somewhat controversial but this change does the following:

The idea is that if there's only one visible tab in a stack then dragging that tab should equate to dragging the complete stack (including placeholders).

The particular use case is that if the user drags the 'Outline' view to place it under the Package Explorer then opening the Ant view should have it show up in the same stack as Outline rather than taking up the screen real estate on the right.

We'll go with this for 4.1 and see what the users think :).

Comment 6 Eric Moffatt

2011-05-12 15:10:03 EDT

Committed in >20110512. Applied the patch.

Marking this as fixed since this is the last change we expect to make pre-release...