Bugzilla – Full Text Bug Listing
| Summary: | Fetch patchset from task editor into Git repository | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Sascha Scholz <sascha.scholz> | ||||
| Component: | Mylyn | Assignee: | Sascha Scholz <sascha.scholz> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | steffen.pingel | ||||
| Version: | unspecified | Keywords: | noteworthy | ||||
| Target Milestone: | 0.8 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Sascha Scholz
http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.reviews.git/log/?h=sscholz/fetch-from-task-editor It would be very nice if someone could review my commit. Thx. For the above change I haven't managed to get the target definition working (tried only with 3.6). First I had to reorder the repository entries to get the Mylyn 3.5.0 at all (otherwise the target editor only resolved 3.4.0). Then I tried to add <unit id="org.eclipse.mylyn.test_feature.feature.group" version="0.0.0"/> to pull in org.eclipse.mylyn.tests.util which is required by org.eclipse.mylyn.gerrit.tests. Worked, but this required org.eclipse.swtbot.eclipse.core 2.0.0 which couldn't be resolved. I have no idea where to get it from or how to search for it. Does anybody have hints how to resolve the mess? I don't know what you are referring to when you say "mess". I have removed the explicit target definitions as this was causing too much maintenance overhead. Note that I plan to abstract that further (bug 339956). Can you try again? In case you are using PDE I recommend the target definitions in org.eclipse.mylyn.releng/target-definitions. Anyways, I think this feature addition is great! By talking about "mess" I wanted to express my feelings about my missing understanding about target definitions... ;-) I'm going to try out the changed configuration soon. However, I don't know if it's a good idea to have separate target platforms for PDE and Tycho. I've always liked the idea of a common definition that I could work with in PDE. Regarding org.eclipse.mylyn.releng/target-definitions you have to take into account that not all of us have committer rights there to share configuration changes. Anyways, thanks for your kudos! ;-) Pushed to master: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.reviews.git/commit/?id=d175641f0241815d3d735e986b0cb7b877cf62e9 Created attachment 195679 [details]
screenshot
|