Bugzilla – Full Text Bug Listing
| Summary: | To be able to view facet attributes and facet references in a table | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Nicolas Guyomar <nicolas.guyomar> | ||||||||
| Component: | EMF-Facet | Assignee: | Gregoire Dupe <gdupe> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | emft.facet-inbox, gdupe | ||||||||
| Version: | unspecified | Flags: | gdupe:
indigo+
|
||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | 340941 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Nicolas Guyomar
Created attachment 191908 [details] Patch for Bug 340940 Hi, In this patch I've added the two new requested columns, known as FacetAttributeColumn and FacetReferenceColumn I've extracted the column instantiation from NatTableWidget class to the NatTableWidgetUtils one, created in Bug 340738. This modification is performed in this bug because it is strongly linked with the additions of FacetReference and FacetAttribute Columns. I've deleted TableElement and TableElementWithContext because since the creation of Row in TableInstance model, those classes were both duplicate beans of Row. (impacted class is BodyDataProvider) I've modified the RemoveLineHandler which was not working anymore, this was due to a past modification in the Column selection mechanism. I've modified the ExportCommandHandler because the user was still able to export a QueryResult from a table, but we are not ready for such a functionnality There is an unexternalized string in org.eclipse.emf.facet.widgets.nattable.internal.NatTableWidget.getColumnName(Column) because We are waiting for an answer from Babel to know the process to externalize strings after M6. (http://www.eclipse.org/forums/index.php?t=msg&th=206622&start=0&S=27354c8f22cdb29136360e096646dc78) (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. Regards, Nicolas Guyomar Created attachment 191909 [details] Bug 340940 Additional changes Hi, I forgot to include the FacetContext class, in which I add to change a method visibility for performance matter. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. Regards, Nicolas Guyomar Comment on attachment 191909 [details] Bug 340940 Additional changes Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 458. Comment on attachment 191908 [details] Patch for Bug 340940 Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 458. Created attachment 193365 [details] Patch for Bug 340940 Unit Test Hi, Please find attached a patch on existing loadFacets() unit test which had a cell's content validation on a FacetAttributeColumn. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar Comment on attachment 193365 [details] Patch for Bug 340940 Unit Test Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 525. This bug can be marked as fixed. Regards, Gregoire Dupe This bug can be closed. |