Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340824

Summary:

CycleValidator Logic is wrong

Product:

[Technology] Tigerstripe

Reporter:

Richard Craddock <rcraddoc>

Component:

Core

Assignee:

Project Inbox <tigerstripe.core-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

yuri

Version:

unspecified

Target Milestone:

0.5M0

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
patch	none

Description Richard Craddock

2011-03-23 20:46:44 EDT

In the CycleValidator, the logic is detecting DUPLICATE entries in the dependency graph as errors even when tehy are not cyclical.

eg

A depends on B and C

B depends on C

Will result in an incorrect error marker, because it discovers C twice.

I have disabled the check...

Comment 1 Valentin Yerastov

2011-03-24 18:10:22 EDT

Created attachment 191876 [details]
patch

The issue is fixed.

Comment 2 Yuri Strot

2011-03-24 18:46:49 EDT

Valentin's patch applied.