Bug 340791

Comment 1 Kim Moir 2011-03-24 09:24:51 EDT

Will upgrade basebuilder with next I-build's bundles so I can release this change.

Comment 2 Kim Moir 2011-04-11 14:40:40 EDT

DJ, I changed the way the director is called so the extraArgs include the iuProfileProperties path now

         <ant antfile="${eclipse.pdebuild.scripts}/genericTargets.xml" target="runDirector" inheritAll="true">
                        <property name="p2.repo" value="file:${p2.repo}" />
                        <property name="p2.director.iu" value="${p2.director.installIU}" />
                        <property name="p2.director.installPath" value="${p2.director.install.path}" />
                        <property name="os" value="${p2.os}" />
                        <property name="ws" value="${p2.ws}" />
                        <property name="arch" value="${p2.arch}" />
                        <property name="p2.director.log" value="${directorlog}" />
                        <property name="equinoxLauncherJar" value="${base.builder}/plugins/org.eclipse.equinox.launcher.jar" />
                        <property name="vmargs" value="-Dorg.eclipse.ecf.provider.filetransfer.retrieve.closeTimeout=3000 -Dorg.eclipse.ecf.provider.filetransfer.retrieve.readTimeout=3000"/>
                        <property name="p2.director.extraArgs" value="-profileProperties org.eclipse.update.install.features=true -iuProfileProperties ${equinox.build.configs}/equinox.prov/lock.properties" />
                </ant>

${equinox.build.configs}/equinox.prov/lock.properties looks like this
org.eclipse.sdk.feature.group.key.0=org.eclipse.equinox.p2.type.lock
org.eclipse.sdk.feature.group.value.0=1

However, I can still uninstall the SDK. Any ideas?

Comment 3 DJ Houghton 2011-04-11 14:48:15 EDT

Can you attach the latest profile that is the result of the install? 
Thanks.

Comment 4 Kim Moir 2011-04-11 15:02:13 EDT

Created attachment 192962 [details]
last profile

Comment 5 Kim Moir 2011-04-11 15:03:01 EDT

Created attachment 192963 [details]
previous profile

Comment 6 DJ Houghton 2011-04-11 15:15:23 EDT

Was this a valid build? Were there any error logs? The "last" profile is empty.

Comment 7 Kim Moir 2011-04-11 15:35:36 EDT

Yes, it was a valid build.  The issue is that I shouldn't be able uninstall the SDK, but I can.  "Last profile" refers to the profile where I removed the SDK.  The "previous profile" refers to the initial profile from the build.

Comment 8 Kim Moir 2011-04-11 17:18:30 EDT

DJ, Can you send me a profile where this property is defined?

Comment 9 DJ Houghton 2011-04-11 17:32:02 EDT

The property needs to be set on the org.eclipse.sdk.ide IU like this:

org.eclipse.sdk.ide.key.0=org.eclipse.equinox.p2.type.lock
org.eclipse.sdk.ide.value.0=1

I'm debugging it now but I think there is a problem when there are multiple IUs with the same ID but different version. For instance, I can reproduce this by trying to install the SDK from the i-builds repo. I do a query to see if "org.eclipse.sdk.ide" is a valid IU and it is, but I think the director is trying to set the property on a different version than will be installed, so that's why it fails.

If you are installing from a repository with only a single version, it should work.

Comment 10 Kim Moir 2011-04-11 17:36:02 EDT

Okay thanks DJ, I'll restart the director install with the new property and try installing from a single-child repo.

Comment 11 Kim Moir 2011-04-12 13:57:53 EDT

Created attachment 193081 [details]
patch

Comment 12 Kim Moir 2011-04-12 14:13:04 EDT

It works when there is a single child repo in the composite repo. Also, there was a typo in my build scripts yesterday. I'll close this for now and then update to the newer bundles next week to address bug 342492.