Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340745

Summary: Polish the fix for bug 339197
Product: [Eclipse Project] Platform Reporter: Szymon Ptaszkiewicz <sptaszkiewicz>
Component: ResourcesAssignee: Szymon Ptaszkiewicz <sptaszkiewicz>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 Flags: Szymon.Brandys: review+
Version: 3.7   
Target Milestone: 3.7 M7   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 339197    
Bug Blocks:    
Attachments:
Description Flags
Patch v.0.1
none
Patch v.0.2 Szymon.Brandys: iplog+

Description Szymon Ptaszkiewicz CLA 2011-03-23 07:52:59 EDT 
Created attachment 191742 [details]
Patch v.0.1

Fix for bug 339197 added new lines in ProjectPreference.save(). One of them contains condition that is always true so there is no point to check this condition.
Comment 1 Szymon Ptaszkiewicz CLA 2011-03-23 08:08:16 EDT 
I found also another thing that should be changed there. The patch will follow.
Comment 2 Szymon Ptaszkiewicz CLA 2011-03-23 09:00:46 EDT 
Created attachment 191745 [details]
Patch v.0.2

Derived rule is currently null but in case it may change in the future we should also add it to the combined rule.
Comment 3 Szymon Brandys CLA 2011-03-23 12:04:08 EDT 
Fixed.