Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340715

Summary:	Unhandled patterns
Product:	[Technology] JGit	Reporter:	Robin Rosenberg <robin.rosenberg>
Component:	JGit	Assignee:	Project Inbox <jgit.core-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	robin, roland
Version:	3.0
Target Milestone:	3.1
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:
Bug Depends on:
Bug Blocks:	389304

Description Robin Rosenberg

2011-03-22 18:55:48 EDT

"\[*" is not handled in ignore files. It should match filenames starting with a left square bracked, e.g. saved mail messages containing patches.


org.eclipse.jgit.errors.NoClosingBracketException: No closing ] found for [ at index 1.
	at org.eclipse.jgit.fnmatch.FileNameMatcher.findGroupEnd(FileNameMatcher.java:205)
	at org.eclipse.jgit.fnmatch.FileNameMatcher.parseHeads(FileNameMatcher.java:253)
	at org.eclipse.jgit.fnmatch.FileNameMatcher.createHeadsStartValues(FileNameMatcher.java:158)
	at org.eclipse.jgit.fnmatch.FileNameMatcher.<init>(FileNameMatcher.java:140)
	at org.eclipse.jgit.ignore.IgnoreRule.setup(IgnoreRule.java:108)
	at org.eclipse.jgit.ignore.IgnoreRule.<init>(IgnoreRule.java:75)
	at org.eclipse.jgit.ignore.IgnoreNode.parse(IgnoreNode.java:106)
	at org.eclipse.jgit.treewalk.WorkingTreeIterator$RootIgnoreNode.loadRulesFromFile(WorkingTreeIterator.java:927)
	at org.eclipse.jgit.treewalk.WorkingTreeIterator$RootIgnoreNode.load(WorkingTreeIterator.java:917)
	at org.eclipse.jgit.treewalk.WorkingTreeIterator.getIgnoreNode(WorkingTreeIterator.java:487)
	at org.eclipse.jgit.treewalk.WorkingTreeIterator.isEntryIgnored(WorkingTreeIterator.java:461)
	at org.eclipse.jgit.treewalk.WorkingTreeIterator.isEntryIgnored(WorkingTreeIterator.java:448)
	at org.eclipse.egit.core.ContainerTreeIterator.isEntryIgnored(ContainerTreeIterator.java:164)
	at org.eclipse.egit.ui.internal.decorators.DecoratableResourceHelper.decorateResource(DecoratableResourceHelper.java:217)
	at org.eclipse.egit.ui.internal.decorators.DecoratableResourceAdapter.extractResourceProperties(DecoratableResourceAdapter.java:109)
	at org.eclipse.egit.ui.internal.decorators.DecoratableResourceAdapter.access$3(DecoratableResourceAdapter.java:108)
	at org.eclipse.egit.ui.internal.decorators.DecoratableResourceAdapter$RecursiveStateFilter.include(DecoratableResourceAdapter.java:203)
	at org.eclipse.jgit.treewalk.filter.AndTreeFilter$Binary.include(AndTreeFilter.java:131)
	at org.eclipse.jgit.treewalk.TreeWalk.next(TreeWalk.java:560)
	at org.eclipse.egit.ui.internal.decorators.DecoratableResourceAdapter.extractContainerProperties(DecoratableResourceAdapter.java:270)
	at org.eclipse.egit.ui.internal.decorators.DecoratableResourceAdapter.<init>(DecoratableResourceAdapter.java:95)
	at org.eclipse.egit.ui.internal.decorators.DecoratableResourceHelper.createDecoratableResources(DecoratableResourceHelper.java:94)
	at org.eclipse.egit.ui.internal.decorators.GitLightweightDecorator.prepareDecoration(GitLightweightDecorator.java:340)
	at org.eclipse.egit.ui.internal.decorators.GitLightweightDecorator.processDecoration(GitLightweightDecorator.java:322)
	at org.eclipse.egit.ui.internal.decorators.GitDecoratorJob.run(GitDecoratorJob.java:88)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

Comment 1 Roland Schulz

2013-06-04 21:29:03 EDT

This present in 3.0. Possible fix: https://git.eclipse.org/r/#/c/4324/1

Comment 2 Robin Rosenberg

2013-08-10 18:27:45 EDT

I merged https://git.eclipse.org/r/#/c/11558/ instead. Forgot your patch, but I still think i prefer the one I merged.

If you agree, just abandon your patch please.

Comment 3 Robin Rosenberg

2013-08-10 18:28:32 EDT

I merged https://git.eclipse.org/r/#/c/11558/ instead. Forgot your patch, but I still think i prefer the one I merged.

If you agree, just abandon your patch please.

Comment 4 Robin Stocker

2014-04-25 18:25:33 EDT

Fixed in 3.1.