Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340708

Summary: Instances of Connection should respond to double-clicks
Product: [Modeling] Graphiti Reporter: Torkild Resheim <torkildr>
Component: CoreAssignee: Torkild Resheim <torkildr>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: ashw.kumar, michael.wenz, tim.kaiser
Version: 0.8.0Flags: michael.wenz: indigo+
Target Milestone: 0.8.0   
Hardware: All   
OS: All   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=327756
https://bugs.eclipse.org/bugs/show_bug.cgi?id=328933
Whiteboard: Indigo M7 theme_round_offs
Attachments:
Description Flags
Patch to add double-click handling michael.wenz: iplog+

Description Torkild Resheim CLA 2011-03-22 17:17:48 EDT 
In some use cases it would be useful to have connections respond to double-clicks just as other types of shapes. Currently there is no support for this. As far as I can see this enchancement could be implemented in o.e.graphiti.ui.internal.parts.ConnectionEditPart or in o.e.gef.editparts.AbstractConnectionEditPart.

I have a patch for this if there is any interest.
Comment 1 Torkild Resheim CLA 2011-03-22 17:34:34 EDT 
Created attachment 191712 [details]
Patch to add double-click handling

This patch will add double-click handling to connections.
Comment 2 Michael Wenz CLA 2011-03-23 05:16:33 EDT 
*** Bug 328933 has been marked as a duplicate of this bug. ***
Comment 3 Michael Wenz CLA 2011-03-23 05:20:38 EDT 
There was already a bug for this
(https://bugs.eclipse.org/bugs/show_bug.cgi?id=328933), nevertheless I close
the older one to track this here because the patch is contained here.
Comment 4 Michael Wenz CLA 2011-03-23 05:52:18 EDT 
Thanks for the patch, I have just checked-in the change to head.

I had to do one minor change to it: triggering the feature was done in non-standard way (the feature's hasDoneChanges method would have never been called). I have changed the triggering in the same way as I did in bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=327756 for shapes.
Comment 5 Torkild Resheim CLA 2011-03-23 06:13:05 EDT 
Great! Thanks Michael. I have the same problem with Anchors. Will create a separate report for that.
Comment 6 Michael Wenz CLA 2011-03-23 06:21:10 EDT 
Comment on attachment 191712 [details]
Patch to add double-click handling

Set the IPLog flag for the patch
Comment 7 Michael Wenz CLA 2011-06-24 09:13:59 EDT 
Part of Graphiti Indigo 0.8.0