Bugzilla – Full Text Bug Listing
| Summary: | edc - TraceView - dead code & unfinished cleanup when exporting trace log | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Kirk Beitz <kirk.beitz> | ||||
| Component: | cdt-debug-edc | Assignee: | Ken Ryall <ken.ryall> | ||||
| Status: | RESOLVED WONTFIX | QA Contact: | Ken Ryall <ken.ryall> | ||||
| Severity: | minor | ||||||
| Priority: | P3 | CC: | cdtdoug | ||||
| Version: | 7.0.1 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
(this is part of a batch change) The Eclipse CDT EDC (https://wiki.eclipse.org/CDT/cdt-debug-edc) is now obsolete and has not had any active development since 2011. Therefore the still open bugs are being marked as wontfix. The git repo for the project still exists for posterity at https://git.eclipse.org/c/cdt/org.eclipse.cdt.edc.git/ |
Created attachment 191701 [details] refactor to eliminate dead code; additional catch blocks to properly close all in EDCTraceView.java , code analysis reveals a couple of sections of dead code w.r.t. the Reader and Writer in handleExport. this also exposes that the Reader in and Writer out may never properly have .close() called on them, and also that if in.close() throws IOException, out.close() will never be called. the same is true of the result in private copy() … if the reader.close() throws IOException, writer.close() will never be processed.