Bugzilla – Full Text Bug Listing
| Summary: | Facet column implementation | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Nicolas Guyomar <nicolas.guyomar> | ||||||||||||||||||
| Component: | EMF-Facet | Assignee: | Gregoire Dupe <gdupe> | ||||||||||||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||||||||||||
| Severity: | enhancement | ||||||||||||||||||||
| Priority: | P3 | CC: | emft.facet-inbox, gdupe | ||||||||||||||||||
| Version: | unspecified | Flags: | gdupe:
indigo+
|
||||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||||||
| Hardware: | All | ||||||||||||||||||||
| OS: | All | ||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Nicolas Guyomar
Created attachment 191697 [details] Patch for Bug 340681 Hi, I have implemented such a feature in the attached patch. Thank to bug , I was able to get the tableInstance facet registration mechanism to work. We can now apply facets on table, and see FacetAttributes and FacetReferences as new columns. This patch impacts the following projects: org.eclipse.emf.facet.infra.browser org.eclipse.emf.facet.infra.facet.core org.eclipse.emf.facet.widgets.nattable org.eclipse.emf.facet.widgets.nattable.instance org.eclipse.emf.facet.widgets.nattable.workbench (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. Regards, Nicolas Guyomar Created attachment 191699 [details] Patch for Bug 340681 (In reply to comment #1) I forgot to include one plug-in in my patch : org.eclipse.emf.facet.infra.browser.custom.ui Please find attached an updated version (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. Regards, Nicolas Guyomar Comment on attachment 191699 [details] Patch for Bug 340681 Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 444. This bug can be marked has fixed. I reopen this bug to not forget to externalize strings from: - org.eclipse.emf.facet.widgets.nattable.internal.actions.LoadCustomizationsAction - org.eclipse.emf.facet.widgets.nattable.internal.actions.LoadFacetsAction We are waiting for an answer from Babel to know the process to externalize strings after M6. (http://www.eclipse.org/forums/index.php?t=msg&th=206622&start=0&S=27354c8f22cdb29136360e096646dc78) Regards, Gregoire I've fixed the string externalization warnings and add a TODO comment to not forget to externalize string in conformance with the Babel process. (In reply to comment #6) Committed revision 453. We also have to externalize strings form: - org.eclipse.emf.facet.widgets.nattable.internal.NatTableWidget I've added a TODO comment to remind them. (Committed revision 456.) Regards, Gregoire Dupe Created attachment 192069 [details] Patch for Bug 340681 update Hi, Please find attached a new patch in order to update the FacetColumn implementation. In this patch I have added icon in the FacetReferenceColumn and FacetAttributeColumn header. It is now possible to set the applied facet using the table contextual menu I have extracted some static methods from NatTableWidget java class to NatTableWidgetInternalUtils I have also modified the tableConfiguration loading, so that whenever a referenced does not exist in the FacetCatalog, the framework does not try to apply it but log an error (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. Regards, Nicolas Guyomar Comment on attachment 192069 [details] Patch for Bug 340681 update Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 464. Created attachment 192073 [details] Bug 340681 modifications needed for tests Hi, Please find attached some new x-friends, as well as a new method selectDefaultLabelCell() in INatTableWidget2 needed fo the upcoming test plug-in (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. Regards, Nicolas Guyomar Created attachment 192074 [details]
New Plug-in : org.eclipse.emf.facet.widgets.nattable.tests
Hi,
Please find attached a new test plug-in for NatTable.
(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
Regards,
Nicolas Guyomar
Comment on attachment 192073 [details] Bug 340681 modifications needed for tests Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 465. Created attachment 192082 [details] Patch Bug 340681 example plugin for tests Hi, Please find attached some new test material for table testing. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. Regards, Nicolas Guyomar *** Bug 340976 has been marked as a duplicate of this bug. *** Created attachment 192084 [details]
updated documentation.patch
Hi,
Please find attached an updated version of the table documentation, images are attached in the next attachment.
(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
Regards,
Nicolas Guyomar
Created attachment 192085 [details]
new_user_documentation_icons.zip
Hi,
Please find attached some new images for the table user documentation
(a) I, Nicolas Guyomar, authored 100% of the images I've provided.
(b) I have the right to contribute the image to Eclipse.
(c) I contribute the content under the EPL.
Regards,
Nicolas Guyomar
Comment on attachment 192082 [details] Patch Bug 340681 example plugin for tests Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 467. Comment on attachment 192074 [details] New Plug-in : org.eclipse.emf.facet.widgets.nattable.tests Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 470. Comment on attachment 192084 [details] updated documentation.patch Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 473. Comment on attachment 192085 [details] new_user_documentation_icons.zip Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 473. This bug can be closed. |