Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340638

Summary:

GProf view presents border around table

Product:

[Tools] Linux Tools

Reporter:

John Dallaway <john>

Component:

GProf

Assignee:

Xavier Raynaud <xavier.raynaud>

Status:

RESOLVED FIXED

QA Contact:

Xavier Raynaud <xavier.raynaud>

Severity:

trivial

Priority:

Version:

unspecified

Target Milestone:

0.8.0

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
GmonView.java.patch	overholt: iplog+

Description John Dallaway

2011-03-22 06:49:35 EDT

Build Identifier: I20100608-0911

The GProf view presents a border around its table. This is inconsistent with the GCov view and other Eclipse views which use a table to present data (eg the "Problems" view).

Reproducible: Always

Comment 1 John Dallaway

2011-03-22 06:54:14 EDT

Created attachment 191664 [details]
GmonView.java.patch

This patch resolves the reported issue by overriding AbstractSTDataView#createPartControl() in GMonView, as in GCovView.

Comment 2 Xavier Raynaud

2011-03-22 10:29:43 EDT

fixed in git:
http://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.git/commit/?id=3ae11a1ba3133f2257dad079e12862481ac266d9

Thanks, John.

Comment 3 John Dallaway

2011-03-24 06:09:21 EDT

Great. Thank you for processing the patch.

Comment 4 Andrew Overholt

2011-03-28 13:41:11 EDT

Comment on attachment 191664 [details]
GmonView.java.patch

Thanks for the patch, John!

Xavier, please mark patches that you accept with the iplog+ flag.  Thanks.