Bugzilla – Full Text Bug Listing
| Summary: | Support configurable colors in EGit History view | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Kevin Sawicki <kevin> | ||||
| Component: | UI | Assignee: | Project Inbox <egit.ui-inbox> | ||||
| Status: | NEW --- | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | chad.bamford7, robin | ||||
| Version: | unspecified | Keywords: | helpwanted | ||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: |
https://git.eclipse.org/r/55509 https://git.eclipse.org/c/egit/egit.git/commit/?id=d731994757fe6d4ffa076441124a22072de41898 |
||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Kevin Sawicki
Not just for "lines and dots', but all textual items too :)! Those links are awfully hard to read against a dark background Could you attach a screenshot? Created attachment 237519 [details]
Screenshot of links in revision/commit view pane of history view
The colors (I'm particularly refering to) are coded in org.eclipse.egit.ui.internal.history.CommitMessageViewer.java (lines 77-93).
[Interesting - from the Platform Plug-in Development Guide (Kepler): What's New?: SWT Changes : A new constant (SWT_COLOR_LINK_FOREGROUND) has been added that returns the native color of hyperlinks on all platforms.
Still trying to create build environment for EGit on Kepler (looks like p2 needs some work).
(In reply to Chad Bamford from comment #3) > Created attachment 237519 [details] > Screenshot of links in revision/commit view pane of history view We're currently considering changing how the information is displayed there to be more like in the commit viewer. Do the links and the diff there look better for you? Right click on a commit in the history and select Open in Commit Viewer. > [Interesting - from the Platform Plug-in Development Guide (Kepler): What's > New?: SWT Changes : A new constant (SWT_COLOR_LINK_FOREGROUND) has been > added that returns the native color of hyperlinks on all platforms. Interesting. Unfortunately, we can't yet use this as our current policy is to support the current version of Eclipse and the one before. > Still trying to create build environment for EGit on Kepler (looks like p2 > needs some work). Are you refering to bug 409073? Note that it's not necessary to install all tools from there, using a target platform as described here should be enough for the dependencies: https://wiki.eclipse.org/EGit/Contributor_Guide#Option_1:_Use_a_Target_Platform If you have any problems, don't hesitate to write to the mailing list (we're friendly :)), we want contributing to be as straightforward as possible. New Gerrit change created: https://git.eclipse.org/r/55509 Gerrit change https://git.eclipse.org/r/55509 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=d731994757fe6d4ffa076441124a22072de41898 |