Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340622

Summary: alt+click hover affordance appears when no task active
Product: z_Archived Reporter: Sam Davis <sam.davis>
Component: MylynAssignee: Shawn Minto <shawn.minto>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: shawn.minto, steffen.pingel
Version: unspecified   
Target Milestone: 3.5.1   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
patch
none
mylyn/context/zip none

Description Sam Davis CLA 2011-03-22 00:36:11 EDT
I am seeing the alt+click hover affordance in the package explorer without a task active. It went away after closing and reopening the package explorer, but when I restarted Eclipse, it was there again.
Comment 1 Sam Davis CLA 2011-03-22 00:50:06 EDT
In the installation where this is happening, I can reproduce it consistently. It happens every time I do the following:

# start eclipse and wait for everything to load
# activate a task which has context
# hover over a project in the package explorer so that the + appears
# deactivate the task
# hover on the project again and the + still appears
Comment 2 Sam Davis CLA 2011-03-22 00:51:50 EDT
It happened just now omitting step 3, but I don't know if it will do that consistently.
Comment 3 Steffen Pingel CLA 2011-04-03 19:58:20 EDT
This is different from bug 341589, right?
Comment 4 Sam Davis CLA 2011-04-04 12:01:32 EDT
Yes. The affordance behaves normally (it only appears on the element I am hovering over) except that it makes no difference whether a task is active or not.
Comment 5 Shawn Minto CLA 2011-04-07 17:46:52 EDT
Created attachment 192784 [details]
patch

It turns out that there is a case where the the drawer could be instantiated twice and therefore when it is removed, only 1 is properly removed instead of both.  This patch adds supports o that the FilteredTreeDecorationDrawer knows whether it is already installed or not and wont install itself if it had been already.
Comment 6 Shawn Minto CLA 2011-04-07 17:46:55 EDT
Created attachment 192785 [details]
mylyn/context/zip
Comment 7 Shawn Minto CLA 2011-04-07 17:48:14 EDT
patch committed.  Steffen, leaving open for backporting if we do a Mylyn 3.5.1.
Comment 8 Steffen Pingel CLA 2011-04-08 04:23:15 EDT
Patch applied to e_3_7_m_3_5_x branch.
Comment 9 Shawn Minto CLA 2011-04-08 11:45:58 EDT
Thanks Steffen!