Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340595

Summary:	256x256 program-launcher icons on Windows not supported
Product:	[Eclipse Project] PDE	Reporter:	Andy Thomas-Cramer <thomascramera>
Component:	Build	Assignee:	pde-build-inbox <pde-build-inbox>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	normal
Priority:	P3	CC:	aniefer, jonas.ruettimann, Kalfje, olabrosse, Tod_Creasey
Version:	4.0
Target Milestone:	---
Hardware:	PC
OS:	Windows Vista
Whiteboard:

Description Andy Thomas-Cramer

2011-03-21 14:31:22 EDT

Build Identifier: I20100608-0911

Windows *.ico files can include 256x256 images. These are visible, for example, with View>Extra Large Icons. 

However, an Eclipse RCP application cannot specify a 256x256 image on the *.product wizard on the "Launching" tab, and *.ico files including a 256x256 image are not accepted.
 
An example of this can be seen in the launch icon for the Eclipse Helios Java IDE. 

Given:
- A 256x256 image is included in the *.ico file specified in an RCP app's *.product, on the Launching tab, under "Program Launcher," on the win32 inner tab, in the "Use a single ICO file containing the 6 images."
- The Windows Vista explorer can display the icon at all resolutions. 

Observed: 
- A warning is provided by the *.product wizard: "The specified path does not point to a valid image."
- The default Eclipse icon is used on the exported product, at *all* resolutions.

Expected:
- The *.ico that worked in Windows would also be accepted by Eclipse.
- The 256x256 image would either be used (ideal) or ignored.


Reproducible: Always

Steps to Reproduce:
1.A 256x256 image is included in the *.ico file specified in an RCP app's *.product, on the Launching tab, under "Program Launcher," on the win32 inner tab, in the "Use a single ICO file containing the 6 images."
2.
3.

Comment 1 Andrew Niefer

2011-03-21 14:42:11 EDT

PDE/Build can only replace images that already exist in the launcher binary, it can't add or remove icons.


Open question is this: what happens if a 256x256 icon is added to the launcher and RCP apps don't start including this icon.  They are left with a 256 sized eclipse icon and then their own small icons.

Comment 2 Andy Thomas-Cramer

2011-05-10 16:52:20 EDT

Andrew, in that case -- when a 256x256 is missing but others are not -- could the behavior be to generate a 256x256 from the closest specified image? 

(It wouldn't have to be interpolation for smaller images; could just drop the image pixel-for-pixel onto the larger 256x256 grid. Looks like this is what Windows Vista does.)

Comment 3 Marijn Bekers

2011-05-15 20:27:12 EDT

The problem is worsened by the fact that eclipse.exe contains a seventh image at 24x24 resolution.
For some reason, Windows 7 decides to use that icon for all display sizes except 'Details' (or 'Small Icons') in explorer.

Given:
- An *.ico file containing the required six icons at correct resolution and bbp is added to the product configuration
- The product is exported normally

Observed:
- With explorer view set to "Details", the correct icon (16x16) is shown
- When explorer view is set to "Medium Icons" or larger, the Eclipse icon is shown.
- The executable inspected with an icon editor reveals a 24x24 eclipse icon in the executable.

Expected:
At all zoom levels, at least some rendering of my own icon should be used.

Comment 4 John Arthorne

2012-05-10 15:59:42 EDT


*** This bug has been marked as a duplicate of bug 378662 ***