Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340461

Summary:	[client] Should the inline compare editor have syntax highlighting?
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	libingw, Szymon.Brandys, tomasz.zarna
Version:	0.2
Target Milestone:	1.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	334213

Description Mark Macdonald

2011-03-18 12:55:36 EDT

1. Link a Git repository to a folder in your Orion workspace.
2. Commit a change to a .js file in the repository.
3. In the Orion navigator, select the .js file and use the "Git Log" action.
4. Click on the log message, and an editor will open showing the file contents.

The editor doesn't have any JS syntax highlighting.

Comment 1 Szymon Brandys

2012-02-02 04:55:14 EST

Libing is there any way to enable syntax assist in the inline editor?

Comment 2 libing wang

2012-02-02 08:34:16 EST

(In reply to comment #1)
> Libing is there any way to enable syntax assist in the inline editor?

The contents of the in-line viewer is mixed by original text and diff blocks.
I am not sure adding a syntax highlighter against such contents will introduce any funny result but we can try.
The text model used in inline viewer is kind of "sub class" from the general text model. Maybe we can play some tricks on that but I am afraid this will not be targeted for 0.4.

Comment 3 libing wang

2012-10-04 17:23:43 EDT

Already fixed.