Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340429

Summary: Restricted shell doesn't work with git repack ("error: failed to run repack")
Product: Community Reporter: Tomasz Zarna <tomasz.zarna>
Component: GitAssignee: Eclipse Webmaster <webmaster>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: david_williams, jesse.mcconnell
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Tomasz Zarna CLA 2011-03-18 10:11:32 EDT
tzarna@TZARNA /d/workspace/eclipse/web/org.eclipse.orion.server (master)
$ git push
Password:
Counting objects: 63, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (26/26), done.
Writing objects: 100% (41/41), 6.57 KiB, done.
Total 41 (delta 22), reused 0 (delta 0)
Auto packing the repository for optimum performance.
/usr/local/libexec/git-core/git-sh-setup: line 202: uname: command not found
/usr/local/libexec/git-core/git-repack: line 54: rm: command not found
/usr/local/libexec/git-core/git-repack: line 91: mkdir: command not found
/usr/local/libexec/git-core/git-repack: line 91: rm: command not found
git: 'repack' is not a git command. See 'git --help'.

Did you mean this?
        repack
error: failed to run repack
To ssh://tzarna@dev.eclipse.org/gitroot/e4/org.eclipse.orion.server.git
   43ea695..30c1489  master -> master

The push succeed.
Comment 1 Denis Roy CLA 2011-03-18 11:38:57 EDT
I've given you a real shell so that this can go through.  You may need to restart Eclipse to refresh any SSH sessions you have.  I'll try to make the repack work with our restricted shell.
Comment 2 Jesse McConnell CLA 2011-09-30 09:01:40 EDT
A couple of us on jetty are seeing this as well.
Comment 3 Eclipse Webmaster CLA 2011-09-30 10:36:56 EDT
I've added the repack command to the allowed list. Jesse can you let me know if this fixes the issue?  If it doesn't can you send me an email with the errors and we can try a workout a time for some testing.

-M.
Comment 4 Eclipse Webmaster CLA 2011-09-30 16:53:38 EDT
After some more digging I think I found the root issue.  I've patched the restricted shell and asked Jesse has confirmed the errors are gone.

-M.