Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340426

Summary: [eclipse-build] Should we backport patch for ant 1.8.2 integration?
Product: [Tools] Linux Tools Reporter: Niels Thykier <niels>
Component: eclipse-buildAssignee: Niels Thykier <niels>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: akurtakov, overholt
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on: 302296    
Bug Blocks:    
Attachments:
Description Flags
Backported ant 1.8.2 support none

Description Niels Thykier CLA 2011-03-18 09:56:33 EDT 
Build Identifier: Irrelevant

Hi

#340422 has been fixed now, but as far as I can tell we will not see it until 3.7, so I was wondering if we should backport it to e-b and then migrate to ant 1.8.2.

~Niels


Reproducible: Always
Comment 1 Alexander Kurtakov CLA 2011-03-28 10:02:28 EDT 
Latest Fedora ships with Ant 1.8.2 if Debian does that too I would say let's backport it.
Comment 2 Niels Thykier CLA 2011-03-28 11:58:11 EDT 
I am okay with bumping to ant 1.8.2 already now even though Debian does not have it (I suspect Ubuntu does not either).  It is less of a headache for me to upgrade ant before finishing eclipse 3.6 than the other way around.

~Niels
Comment 3 Alexander Kurtakov CLA 2011-04-05 10:03:34 EDT 
Another patch that removes ant-nodeps and ant-trax has been merged resulting into eclipse-build mandating Ant 1.8.2 usage.
Comment 4 Andrew Overholt CLA 2011-04-05 10:08:01 EDT 
(In reply to comment #3)
> Another patch that removes ant-nodeps and ant-trax has been merged resulting
> into eclipse-build mandating Ant 1.8.2 usage.

We should make sure this is documented on the eclipse-build wiki page:

http://wiki.eclipse.org/Linux_Tools_Project/Eclipse_Build
Comment 5 Alexander Kurtakov CLA 2011-04-05 10:12:29 EDT 
Done.
Niels, please backport whatever you think is relevant.
Comment 6 Niels Thykier CLA 2011-05-13 07:46:48 EDT 
Created attachment 195581 [details]
Backported ant 1.8.2 support

Upstreams on patch applied almost cleanly against the 3.6.2 tarball we currently link to from [1] after I had split it properly, so I decided to use it mostly as is.
  I had to pull a newer version of AntModelProject from upstream vcs to make it work properly though.

The patch is created against the master branch of eclipse-build (2edc608 at the time of writing).

~Niels

[1] http://download.eclipse.org/technology/linuxtools/eclipse-build/
Comment 7 Andrew Overholt CLA 2011-05-24 11:34:45 EDT 
Alex, are you okay with Niels' proposed patch?
Comment 8 Alexander Kurtakov CLA 2011-05-24 11:45:30 EDT 
Well, assuming that we are not going to make new e-b release based on 3.6.2 tarball we should not need this patch anymore.
Comment 9 Andrew Overholt CLA 2011-05-24 13:32:21 EDT 
I'm sure some distributions will continue to ship 3.6.x for a while yet so we should try to maintain things as best as we can.  At least for bug fix patches as necessary.
Comment 10 Niels Thykier CLA 2011-05-24 16:07:31 EDT 
Actually I suspect we need a revised patch here, if any.  As I recall it is missing an import statement in one of the files it patches (and the build does not fail because the bloody build system ignores build failures!).
  I got the fixed patch on another machine, so I cannot attach it here.  That being said this patch does not fix add real editor support for ant 1.8.2 (e.g. the editor still gives errors with use of "Extends" targets).  I have subscribed to another bug for that (cannot remember the ID at the moment), but no news so far.

~Niels
Comment 11 Alexander Kurtakov CLA 2011-09-06 08:36:27 EDT 
Was this backported?
Comment 12 Andrew Overholt CLA 2011-09-06 08:55:11 EDT 
I don't think so.  I don't see it on the 3.6 branch.
Comment 13 Alexander Kurtakov CLA 2011-09-23 06:22:34 EDT 
Closing as we are not going to do 3.6 releases anymore