Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340415

Summary:	[R4E] Crash after closing / re-opening of a review
Product:	z_Archived	Reporter:	Alvaro Sanchez-Leon <alvaro.sanchez-leon>
Component:	Mylyn	Assignee:	Alvaro Sanchez-Leon <alvaro.sanchez-leon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	0.9
Hardware:	PC
OS:	All
Whiteboard:

Description Alvaro Sanchez-Leon

2011-03-18 07:46:58 EDT

The reference to the group becomes invalid after closing and re-opening of a review, causing  a null pointer exception

Comment 1 Alvaro Sanchez-Leon

2011-03-20 19:09:33 EDT

The problem was at review closing, the review entry was not removed from the transient list of reviews in the group, 
So when the review was re-opened, EMF would not add it up to the list, since it had an existing entry with the same name (although not valid any more).
So the review was all fine except that it did not have a reference to its parent group (which is taken at the moment it's included in the review list)

So the solution was simply to remove the Review entry in the group during the closing sequence.   

commit b0bda9ca114d5b7abfe35d7bd9046068892937e2
Committer: aleon <alvsan09@gmail.com> 2011-03-18 13:37:37

Comment 2 Steffen Pingel

2011-03-20 21:16:57 EDT

Reopening to fix assignment.

Comment 3 Steffen Pingel

2011-03-20 21:17:12 EDT

Closing.