| Summary: | Trim can go empty after maximizing a part that was restored after being minimized from a maximized shared area | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Eric Moffatt <emoffatt> | ||||
| Component: | UI | Assignee: | Project Inbox <e4.ui-inbox> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | remy.suen | ||||
| Version: | unspecified | Flags: | remy.suen:
review+
|
||||
| Target Milestone: | 4.1 RC4 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Eric Moffatt
(In reply to comment #0) > Left over from fixing bug 332498: > > - in the Java Perspective > - maximize the editor area > - restore the Package Explorer > - Maximize the PE > > You get the same chopped off trim we used to get on a perspective switch Now the trim on the right disappears for me. For the general trim clipping problem, see bug 341497. Created attachment 196902 [details]
Remove the 'MAXIMIZED' state from the currently max'd stack
We do this 'silently' (i.e. without causing an unzoom), then the previously max'd stack gets minimzed normally...
Committed in >20110530. Applied the patch. Remy, could you take a quick look at the patch ? Feel free to re-open if you don't like it... (In reply to comment #4) > Remy, could you take a quick look at the patch ? Feel free to re-open if you > don't like it... Please add a try/finally clause around the true/false switching to ensure that the field gets reset to 'false' even if an exception occurs. Looks fine to me otherwise. Done...thanks remy. Verified in I20110604-2201 |