Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340355

Summary:	[client] The editor does not work for some URIs
Product:	[ECD] Orion	Reporter:	Szymon Brandys <Szymon.Brandys>
Component:	Client	Assignee:	Project Inbox <e4.orion-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	mamacdon, Silenio_Quarti, susan, tomasz.zarna
Version:	0.2
Target Milestone:	0.2
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:
Bug Blocks:	334213

Description Szymon Brandys

2011-03-17 13:46:56 EDT

URIs like http://localhost:8080/git/commit/84cfd3a21658fee0fdb0df523e24153c334f2944/file/E/bundles/org.eclipse.orion.client.git?parts=body return the content of Git commits.

I wanted to open the Orion editor to show the commit content, the link was http://localhost:8080/coding.html#http://localhost:8080/git/commit/84cfd3a21658fee0fdb0df523e24153c334f2944/file/E/bundles/org.eclipse.orion.client.git?parts=body

I noticed that the editor displayed the response from http://localhost:8080/git/commit/84cfd3a21658fee0fdb0df523e24153c334f2944/file/E/bundles/org.eclipse.orion.client.git instead of http://localhost:8080/git/commit/84cfd3a21658fee0fdb0df523e24153c334f2944/file/E/bundles/org.eclipse.orion.client.git?parts=body. So it seems like the parameters of the resource URI are chopped off. 

Could you please fix it?

Comment 1 Mark Macdonald

2011-03-18 12:25:58 EDT

In coding.html we use the hash to store the URL of the resource being edited, and also to provide "line" and "char" parameters in a query-style format, 
Eg. coding.html#/path/to/file.txt?line=25&char=6

This is ambiguous when the resource URL includes "?&". For example we can't distinguish between

> coding.html#file.txt?parts=body

and

> coding.html#file.txt?line=25

This is a design issue that we need to solve.

Comment 2 Mark Macdonald

2011-03-18 12:33:14 EDT

To stop blocking Szymon, I've made coding.html more conservative when it parses the hash. It now only assumes that "char" and "line" are parameters for the editor, and leaves stuff like ?parts=body alone.

I opened Bug 340458 for discussion of our hash-usage approach.