Bugzilla – Full Text Bug Listing
| Summary: | [Import/Export] Button label truncation on Import/Export Preferences dialogs | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Kit Lo <kitlo> | ||||||||
| Component: | IDE | Assignee: | Prakash Rangaraj <prakash> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | Prakash Rangaraj <prakash> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | daniel_megert, prakash | ||||||||
| Version: | 3.7 | ||||||||||
| Target Milestone: | 3.7 M7 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 344453, 440093 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 191376 [details]
Export Preferences
In the screenshots the text of all the controls are appended with G[ and ends with ] How did you get to this state? I generated and used some "pseudo translation language packs". You probably can see the same problem if you replace "Deselect All" with "D e s e l e c t A l l" Created attachment 191808 [details]
Patch v01
Patch v01 released to HEAD Prakash, why did you inline the button creation code and leave the createButton(...) unused, given this is internal code? (In reply to comment #6) > Prakash, why did you inline the button creation code and leave the > createButton(...) unused, given this is internal code? Its not exactly inlining the code. The createButton() method first calls the setButtonLayoutData() and then calls setText(). So the widthHint is not correctly set. The new code will setText() first and then call setButtonLayoutData(). I didn't want to change this logic in createButton() (or remove it), as I was not sure of whether its been used any clients above and its too late in the cycle to break them. (In reply to comment #7) > (In reply to comment #6) > > Prakash, why did you inline the button creation code and leave the > > createButton(...) unused, given this is internal code? > > Its not exactly inlining the code. Yep, I saw that, but it's adding code duplication for which createButton(...) had been added to avoid this. >I didn't want to change this logic in createButton() Is the current behavior of it useful or would they also suffer from the bug? Given it's an internal class a fix in there seems more appropriate. Verified in I20110425-1800 My argument is that the current createButton(...) method can't work for anyone. If people worked around that bug by resizing/layouting after calling that method then their code would still work even after fixing the code in said method. I've created a follow-up bug to clean this up during 3.8 (bug 344453). |
Created attachment 191375 [details] Import Preferences Button label truncation on Import/Export Preferences dialogs If you replace the "Select All" & "Deselect All" button labels with some longer translations, you can see that they are truncated.