Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340252

Summary: IllegalArgumentException while hovering over catalog
Product: [Technology] MPC Reporter: Steffen Pingel <steffen.pingel>
Component: wizardAssignee: Benjamin Muskalla <b.muskalla>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3    
Version: unspecified   
Target Milestone: 1.1   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
patch
none
noiconprovided32.png
none
mylyn/context/zip none

Description Steffen Pingel CLA 2011-03-16 17:37:02 EDT 
If a catalog does not specify a description an exception is logged.

java.lang.IllegalArgumentException: Argument cannot be null
	at org.eclipse.swt.SWT.error(SWT.java:4258)
	at org.eclipse.swt.SWT.error(SWT.java:4192)
	at org.eclipse.swt.SWT.error(SWT.java:4163)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:466)
	at org.eclipse.swt.widgets.Label.setText(Label.java:573)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogToolTip.createDescription(CatalogToolTip.java:73)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogToolTip.createToolTipArea(CatalogToolTip.java:65)
	at org.eclipse.equinox.internal.p2.ui.discovery.util.GradientToolTip.createToolTipContentArea(GradientToolTip.java:57)
	at org.eclipse.jface.window.ToolTip.toolTipShow(ToolTip.java:359)
	at org.eclipse.jface.window.ToolTip.toolTipOpen(ToolTip.java:483)
	at org.eclipse.jface.window.ToolTip.toolTipCreate(ToolTip.java:348)
	at org.eclipse.jface.window.ToolTip.access$2(ToolTip.java:342)
	at org.eclipse.jface.window.ToolTip$ToolTipOwnerControlListener.handleEvent(ToolTip.java:631)
Comment 1 Benjamin Muskalla CLA 2011-04-08 12:09:44 EDT 
Created attachment 192853 [details]
patch

Improved error handling for option attribute (icon and description). Will commit once I have commit rights.
Comment 2 Benjamin Muskalla CLA 2011-04-08 12:10:06 EDT 
Created attachment 192854 [details]
noiconprovided32.png

.
Comment 3 Benjamin Muskalla CLA 2011-04-08 12:10:19 EDT 
Created attachment 192855 [details]
mylyn/context/zip
Comment 4 Benjamin Muskalla CLA 2011-04-19 19:36:21 EDT 
Pushed more robust implementation to master, added fallback icon in case a marketplace doesn't provide an icon.