Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340165

Summary: Endless loop when updating to latest i-build
Product: [Eclipse Project] Equinox Reporter: DJ Houghton <dj.houghton>
Component: p2Assignee: P2 Inbox <equinox.p2-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: daniel_megert, kim.moir, tjwatson
Version: 3.7   
Target Milestone: 3.7 M7   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description DJ Houghton CLA 2011-03-16 10:34:20 EDT
When you update to the latest integration build, there seems to be an endless loop. The progress bar seems to indicate that we are downloading a bunch of pde and platform.doc JARs over and over again.

This was a problem for me going from last week's i-build as well as for Tom going from an older build.

If you disable mirrors then the update works ok.
Comment 1 DJ Houghton CLA 2011-03-16 10:45:52 EDT
The artifact is downloading ok but then we are getting this error: 

Status ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Problems downloading artifact: osgi.bundle,org.eclipse.pde.core,3.7.0.v20110314. null children=[Status ERROR: org.eclipse.equinox.p2.artifact.repository code=4 File has invalid content:/var/folders/HB/HBfEMTjGG2yPXnbiNibwKE+++TI/-Tmp-/signatureFile7803236949327328159.jar null children=[Status ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Invalid content:org/eclipse/pde/internal/core/converter/PluginConverter.class org.eclipse.osgi.signedcontent.InvalidContentException: The file "org/eclipse/pde/internal/core/converter/PluginConverter.class" in the jar "/var/folders/HB/HBfEMTjGG2yPXnbiNibwKE+++TI/-Tmp-/signatureFile7803236949327328159.jar" has been tampered!]]
Comment 2 DJ Houghton CLA 2011-03-16 14:56:26 EDT
I've confirmed that the pde.core jar in the build is OK but the packed version is not. I have tested that doing an update from a repo without the packed version succeeds. I will ask Kim to remove the bad packed JAR from the update site.
Comment 3 DJ Houghton CLA 2011-03-16 15:04:44 EDT
Kim is going to remove the bad packed JAR from the repo so users can update to this week's i-build.
Going forward, the endless loop is covered by bug 327256.

*** This bug has been marked as a duplicate of bug 327256 ***
Comment 4 DJ Houghton CLA 2011-03-16 17:43:43 EDT
I've verified that the change has been replicated and you can now update to the latest build while pointing to the eclipse.org servers. Thanks, Kim.
Comment 5 Kim Moir CLA 2011-03-22 11:58:58 EDT
This is also happening this week, with the same pde.core bundle.

If I run jarsigner -verify against the extracted pde.core packed jar

/home/users/kmoir/pdecore/org.eclipse.pde.core_3.7.0.v20110321.jar
jarsigner: java.lang.SecurityException: SHA1 digest error for org/eclipse/pde/internal/core/converter/PluginConverter.class

The regular jar seems to be fine.

I'll remove the jar and update the metadata again.
Comment 6 Kim Moir CLA 2011-03-22 12:07:25 EDT
Fixed and verified that I could update to I20110322-0800.
Comment 7 Kim Moir CLA 2011-03-22 16:00:53 EDT
I've opened bug 340704 for the problem with the corrupt packed pde.core jar when running p2.process.artifacts