Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340147

Summary: Annoying click sound when closing editors, (Windows only)
Product: [Technology] DLTK Reporter: Bruno Medeiros <bruno.do.medeiros>
Component: CommonAssignee: dltk.common-inbox <dltk.common-inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: bruno.do.medeiros
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Bruno Medeiros CLA 2011-03-16 08:45:15 EDT
Build Identifier: 

In the Windows platform, when you use a DLTK based editor and then close it, you hear one or two browser click sounds. This problem will happen if a DLTK popup has been opened while using the editor, but otherwise there will be no click sound. The click sound is the same as the Internet Explorer click sound.

I investigated this a bit further, and it seem it is due to DLTK usage of the Browser control in BrowserInformationControl. Typically, one or two BrowserInformationControl's are created per editor instance, when hover popups appear. They will only be disposed when the editor is closed, and that's when the click sound is heard.
I compared DLTK's BrowserInformationControl with JFace's BrowserInformationControl, and it seems the difference might be due to this code:
   browser.setJavascriptEnabled(false);
which is present in JFace but not in DLTK. I tried that with the Browser SWT snippet code ( http://dev.eclipse.org/viewcvs/viewvc.cgi/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet128.java?view=co ) and it does seem to make the browser close click sound disappear, although I'm not sure why (probably just some IE strangeness)


Reproducible: Always

Steps to Reproduce:
1. open a DLTK based editor of any DLTK IDE
2. make a documentation hover popup appear
3. close the editor
Comment 1 Bruno Medeiros CLA 2012-02-08 10:52:18 EST
This was present in DLTK 2.0, but it looks like it has been fixed in 3.0, time to close?