Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340088

Summary: [Compatibility] Investigate API tooling errors on 4.2 against 4.1 baseline
Product: [Eclipse Project] Platform Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: CLOSED WONTFIX QA Contact:
Severity: major    
Priority: P3 CC: bokowski, daniel_megert, dean.t.roberts, ob1.eclipse, pwebster
Version: 4.1   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard: stalebug

Description Remy Suen CLA 2011-03-15 16:28:10 EDT
I setup API tooling on a 4.1 Eclipse with org.eclipse.ui.workbench imported as a source bundle in my workspace with a 3.7 baseline and got the following errors.

We can ignore the org.eclipse.ui.presentations stuff but probably need to do something about the rest.

The type org.eclipse.ui.testing.ContributionInfo has been removed from org.eclipse.ui.workbench_3.100.0	MANIFEST.MF	/org.eclipse.ui.workbench/META-INF	line 1	Compatibility Problem

The type org.eclipse.ui.presentations.WorkbenchPresentationFactory has been removed from org.eclipse.ui.workbench_3.100.0	MANIFEST.MF	/org.eclipse.ui.workbench/META-INF	line 1	Compatibility Problem

The type org.eclipse.ui.presentations.PresentationUtil has been removed from org.eclipse.ui.workbench_3.100.0	MANIFEST.MF	/org.eclipse.ui.workbench/META-INF	line 1	Compatibility Problem

The type org.eclipse.ui.IWorkbenchPropertyPageMulti has been removed from org.eclipse.ui.workbench_3.100.0	MANIFEST.MF	/org.eclipse.ui.workbench/META-INF	line 1	Compatibility Problem

The method org.eclipse.ui.IWorkingSetManager.setRecentWorkingSetsLength(int) has been removed	IWorkingSetManager.java	/org.eclipse.ui.workbench/src/org/eclipse/ui	line 36	Compatibility Problem

The method org.eclipse.ui.IWorkingSetManager.getRecentWorkingSetsLength() has been removed	IWorkingSetManager.java	/org.eclipse.ui.workbench/src/org/eclipse/ui	line 36	Compatibility Problem

The method org.eclipse.ui.handlers.HandlerUtil.getActiveEditorInputChecked(ExecutionEvent) has been removed	HandlerUtil.java	/org.eclipse.ui.workbench/src/org/eclipse/ui/handlers	line 37	Compatibility Problem

The method org.eclipse.ui.handlers.HandlerUtil.getActiveEditorInput(ExecutionEvent) has been removed	HandlerUtil.java	/org.eclipse.ui.workbench/src/org/eclipse/ui/handlers	line 37	Compatibility Problem

The major version should be incremented in version 3.100.0.v20110311-1500, since API breakage occurred since version 3.7.0.I20110307-1300	MANIFEST.MF	/org.eclipse.ui.workbench/META-INF	line 71	Version Numbering Problem

The field org.eclipse.ui.menus.MenuUtil.WORKBENCH_MENU has been removed	MenuUtil.java	/org.eclipse.ui.workbench/src/org/eclipse/ui/menus	line 21	Compatibility Problem

The field org.eclipse.ui.IWorkbenchPreferenceConstants.RECENTLY_USED_WORKINGSETS_SIZE has been removed	IWorkbenchPreferenceConstants.java	/org.eclipse.ui.workbench/src/org/eclipse/ui	line 30	Compatibility Problem

The field org.eclipse.ui.IWorkbenchCommandConstants.WINDOW_LOCK_TOOLBAR has been removed	IWorkbenchCommandConstants.java	/org.eclipse.ui.workbench/src/org/eclipse/ui	line 21	Compatibility Problem

The field org.eclipse.ui.IWorkbenchCommandConstants.VIEWS_SHOW_VIEW_SECONDARY_ID has been removed	IWorkbenchCommandConstants.java	/org.eclipse.ui.workbench/src/org/eclipse/ui	line 21	Compatibility Problem

The field org.eclipse.ui.contexts.IContextService.CONTEXT_ID_WORKBENCH_MENU has been removed	IContextService.java	/org.eclipse.ui.workbench/src/org/eclipse/ui/contexts	line 40	Compatibility Problem
Comment 1 Remy Suen CLA 2011-07-12 09:47:47 EDT
(In reply to comment #0)
> The type org.eclipse.ui.presentations.WorkbenchPresentationFactory has been
> removed from org.eclipse.ui.workbench_3.100.0    MANIFEST.MF   
> /org.eclipse.ui.workbench/META-INF    line 1    Compatibility Problem
> 
> The type org.eclipse.ui.presentations.PresentationUtil has been removed from
> org.eclipse.ui.workbench_3.100.0    MANIFEST.MF   
> /org.eclipse.ui.workbench/META-INF    line 1    Compatibility Problem

These are the last two remaining problems (ignoring complaints about version number increases in the manifest files). I suppose we could add them back and mark them as being deprecated.
Comment 2 Paul Webster CLA 2011-07-12 09:58:25 EDT
I made 4.1 our baseline for 4.2, and it complains about other stuff.  i.e. workbench should be 3.102.0 and there are 2 since filters that it doesn't like ('cause they say 3.7)
Comment 3 Paul Webster CLA 2011-07-12 11:52:04 EDT
(In reply to comment #2)
> I made 4.1 our baseline for 4.2, and it complains about other stuff.  i.e.
> workbench should be 3.102.0 and there are 2 since filters that it doesn't like
> ('cause they say 3.7)

OK, I've pushed my changes as prep for using a 4.1 baseline.

PW
Comment 4 Dani Megert CLA 2011-11-08 04:14:16 EST
>   i.e. workbench should be 3.102.
This is correct for 4.2 but not for 4.1.1. Currently both streams use the same bundle version which is doomed to fail. Since R4.1.1 is already out the door, the only thing we can do is to change the bundle version in 4.2 to 3.103.0. Filed bug 363130  to track that.
Comment 5 Dean Roberts CLA 2011-11-08 10:54:00 EST
Should this bug be closed?

My interpretation is that we are too late for 4.1.1 and a separate bug was opened, fixed and closed for 4.2
Comment 6 John Arthorne CLA 2012-06-05 10:35:37 EDT
I ran a scan against 4.2 RC3, and the only remaining issue was the deleted class:

org.eclipse.ui.presentations.WorkbenchPresentationFactory

We could restore the API in non-functional form but I think this missed the boat for 4.2. I suggest just adding to the porting guide entry on presentation API brekage and close.
Comment 7 Lars Vogel CLA 2019-11-27 07:19:16 EST
This bug hasn't had any activity in quite some time. Maybe the problem got
resolved, was a duplicate of something else, or became less pressing for some
reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it.
The information can be, for example, that the problem still occurs, that you
still want the feature, that more information is needed, or that the bug is
(for whatever reason) no longer relevant.

If the bug is still relevant, please remove the stalebug whiteboard tag.