Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340079

Summary: [Generators] Tigerstripe ignores min/max version of generators
Product: [Technology] Tigerstripe Reporter: Navid Mehregani <nmehrega>
Component: CoreAssignee: Project Inbox <tigerstripe.core-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: yuri
Version: unspecified   
Target Milestone: 0.5M0   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
340079 patch none

Description Navid Mehregani CLA 2011-03-15 15:07:03 EDT 
Build Identifier: 

When specifying a minimum version for a generator in tigerstripe.xml and the minimum version is not available, an NPE is thrown.

Reproducible: Always

Steps to Reproduce:
1. Create a generator project and specify a version of 1.0
2. Package and deploy your generator
3. Create a TS project
4. Open tigerstripe.xml file of TS project > switch to generator tab > expand generator that was just deployed > enable it > specify a minimum version of 2.0
5. Trigger generation on the project, notice the following NPE in Error Log:

java.lang.NullPointerException
at org.eclipse.tigerstripe.workbench.ui.internal.wizards.generate.NewTigerstripeRunWizardPage.updatePluginsControls(NewTigerstripeRunWizardPage.java:666)
at org.eclipse.tigerstripe.workbench.ui.internal.wizards.generate.NewTigerstripeRunWizardPage.updatePage(NewTigerstripeRunWizardPage.java:604)
at org.eclipse.tigerstripe.workbench.ui.internal.wizards.generate.NewTigerstripeRunWizardPage.createControl(NewTigerstripeRunWizardPage.java:211)
at org.eclipse.jface.wizard.Wizard.createPageControls(Wizard.java:170)
at org.eclipse.jface.wizard.WizardDialog.createPageControls(WizardDialog.java:734)
at org.eclipse.jface.wizard.WizardDialog.createContents(WizardDialog.java:606)
at org.eclipse.jface.window.Window.create(Window.java:431)
at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1089)
at org.eclipse.tigerstripe.workbench.ui.internal.actions.AbstractOpenWizardAction.run(AbstractOpenWizardAction.java:162)
at org.eclipse.tigerstripe.workbench.ui.internal.actions.OpenGenerateInterfaceWizardAction.run(OpenGenerateInterfaceWizardAction.java:79)
at org.eclipse.tigerstripe.workbench.ui.internal.handlers.TigerstripeCommandHandler.execute(TigerstripeCommandHandler.java:61)
at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
at org.eclipse.ui.menus.CommandContributionItem.handleWidgetSelection(CommandContributionItem.java:820)
at org.eclipse.ui.menus.CommandContributionItem.access$19(CommandContributionItem.java:806)
at org.eclipse.ui.menus.CommandContributionItem$5.handleEvent(CommandContributionItem.java:796)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:3776)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1367)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1390)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1375)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1187)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3622)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3277)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2629)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2593)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2427)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:670)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:663)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
at org.eclipse.equinox.launcher.Main.run(Main.java:1407)
at org.eclipse.equinox.launcher.Main.main(Main.java:1383)
Comment 1 Navid Mehregani CLA 2011-03-24 15:24:01 EDT 
This problem is actually just in the SDK and not in Tigerstripe.  It'll be tracked in an internal JIRA.
Comment 2 Anton Salnik CLA 2011-04-01 07:17:23 EDT 
Created attachment 192346 [details]
340079 patch

As it turned out the problem was Tigerstripe relative.
Comment 3 Navid Mehregani CLA 2011-04-01 09:36:54 EDT 
Thanks Anton
Comment 4 Navid Mehregani CLA 2011-04-01 09:37:27 EDT 
Reopening bug so Yuri can review and submit patch
Comment 5 Yuri Strot CLA 2011-04-04 05:12:46 EDT 
Patch submitted.
Comment 6 Navid Mehregani CLA 2011-04-04 16:16:45 EDT 
Verified. Thanks! I modified the error message to be more specific.