Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340072

Summary:

Backport to 3.2.x Change access modifier for SystemSearchPage methods to protected from private

Product:

[Tools] Target Management

Reporter:

David McKnight <dmcknigh>

Component:

RSE

Assignee:

David McKnight <dmcknigh>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

xuanchen

Version:

3.2

Flags:

xuanchen: review+

Target Milestone:

3.2.2+

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

340069

Bug Blocks:

Attachments:

Description	Flags
backport patch	none
updated patch	none

Description David McKnight

2011-03-15 13:54:42 EDT

This bug is for the backport of the fix for bug 340069 to the R3_2_maintenance stream.

Comment 1 David McKnight

2011-03-15 13:57:29 EDT

Created attachment 191234 [details]
backport patch

Comment 2 David McKnight

2011-03-15 13:57:48 EDT

Xuan, could you please review this patch?

Comment 3 Xuan Chen

2011-03-15 14:09:46 EDT

The fix looks good.  Thanks.

Comment 4 David McKnight

2011-03-15 14:17:41 EDT

Created attachment 191236 [details]
updated patch

Comment 5 David McKnight

2011-03-15 14:18:30 EDT

Sorry, Xuan - could you review the updated patch? I had to make an additional change.

Comment 6 Xuan Chen

2011-03-15 14:20:26 EDT

Reviewed.  Thanks.

Comment 7 David McKnight

2011-03-15 14:26:13 EDT

Thanks for the review, Xuan.  I've committed the change to the R3_2_maintenance stream.