Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340008

Summary: Consider Window#setExceptionHandler() to have session scope
Product: [RT] RAP Reporter: Rüdiger Herrmann <ruediger.herrmann>
Component: JFaceAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: philippe.nembrard, ruediger.herrmann
Version: unspecified   
Target Milestone: 1.4 M7   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Session scoped exceptionHandler none

Description Rüdiger Herrmann CLA 2011-03-15 08:10:47 EDT 
Currently the JFace exception handler has application spope (Window#exceptionHandler is a static field).
The way in which it is used by the workbench suggests that it should have session sope (also see bug 340007). In addition, the exception handler having application scope prevents multiple sessions from having different exception handling strageies. Imagine workbench and non-workbench entry points running side by side.
Comment 1 Ivan Furnadjiev CLA 2011-03-18 04:53:22 EDT 
As bug 340007 has been fixed and org.eclipse.ui.internal.ExceptionHandler now has a session scope, we need to take care about Window#exceptionHandler too. It is set in Workbench#runUI().
Comment 2 Ivan Furnadjiev CLA 2011-03-18 06:14:52 EDT 
Created attachment 191495 [details]
Session scoped exceptionHandler
Comment 3 Ivan Furnadjiev CLA 2011-03-18 08:41:37 EDT 
Applied patch to CVS HEAD.