Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339989

Summary: [Class Diagram] Refactor gmfgen
Product: [Modeling] Papyrus Reporter: Patrick Tessier <Patrick.Tessier>
Component: CoreAssignee: Patrick Tessier <Patrick.Tessier>
Status: CLOSED FIXED QA Contact: Yann Tanguy <yann.tanguy>
Severity: normal    
Priority: P3 CC: vincent.lorenzo
Version: 0.8.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch none

Description Patrick Tessier CLA 2011-03-15 05:49:29 EDT
Refactor the gmfgen in order to obtain a more complete gmfgen
	--> Add a display name
	--> default size
	--> good name for editpart
Comment 1 Patrick Tessier CLA 2011-03-15 11:43:05 EDT
Commit generated code without modification in the gmfgen  before doing modification (done in the revision 4305)
Comment 2 Patrick Tessier CLA 2011-03-15 11:47:58 EDT
the DisplayName of commentLinkDescriptorEditpart is now  "AssociationClassDashedLink" done in the revision 4306
Comment 3 Patrick Tessier CLA 2011-03-16 06:14:21 EDT
the DisplayName of AssociationClass2Editart is now "AssociationClassLink" done in the revision 4310
Comment 4 Patrick Tessier CLA 2011-03-16 10:41:55 EDT
AddedLinkEditPart has only a notationType and its display name is now "ContainmentSubLink" done in the revision 4314
Comment 5 Patrick Tessier CLA 2011-03-16 10:52:17 EDT
the display name of  containmentLinkEditpart is now  'ContainmentLink' done in the revision 4315
Comment 6 Patrick Tessier CLA 2011-03-16 11:04:48 EDT
add default size for containmentCircleEditPart (20,20) done in the revision 4316
Comment 7 Patrick Tessier CLA 2011-03-16 11:37:00 EDT
CommentLinkDescriptorEditpart  is now named AssociationClassDashedLinkEditPart done is the revision 4316
Comment 8 Patrick Tessier CLA 2011-03-16 12:15:50 EDT
AssociationClass2EditPart -->AssociationClassLinkEditPart
		-->  AssociationClass2CreateCommand->AssociationClassLinkCreateCommand
		--> AssociationClass2ItemSemanticEditPolicy ->AssociationClassLinkItemSemanticEditPolicy
		--> AssociationClassReorientCommand -> AssociationClassLinkReorientCommand
Done in the revision 4318
Comment 9 Patrick Tessier CLA 2011-03-16 12:51:08 EDT
AddedLinkEditPart -->ContainmentSubLinkEditPart
	*CustomAddedLinkItemSemanticEditpolicy--> CustomContainmentSubLinkItemSemanticEditpolicy
	done in the revision 4320
Comment 10 Patrick Tessier CLA 2011-03-16 13:12:32 EDT
Dependency2EditPart--> DependencyNodeEditPart
*Dependency2CreateCommand--> DependencyNodeCreateCommand
*Dependency2ItemSemanticEditPolicy-->DependencyNodeItemSemanticEditPolicy
diagram.Blockdefinition has been impacted by this modification
done in the revision 4321
Comment 11 Patrick Tessier CLA 2011-03-17 06:27:27 EDT
ClassAttributeCompartmentEditPart--> ClassAttributeCompartmentEditPartCN
ClassAttributeCompartmentItemSemanticEditPolicy-> ClassAttributeCompartmentItemSemanticEditPolicyCN
ClassAttributeCompartmentCanonicalEditPolicy->ClassAttributeCompartmentCanonicalEditPolicyCN
Done in the revision 4323
Comment 12 Patrick Tessier CLA 2011-03-17 06:53:49 EDT
Property4EditPart--> PropertyForClassCNEditPart
Property4ItemSemanticEditPolicy-->PropertyForClassCNItemSemanticEditPolicy
Property4CreateCommand-->PropertyForClassCNCreateCommand
impact in the bloc definition Diagram

done in the revision 4324
Comment 13 Patrick Tessier CLA 2011-03-17 07:11:36 EDT
PropertyEditPart--> PropertyForComponentEditpart
PropertyCreateCommand-->PropertyForComponentCreateCommand
PropertyItemSemanticEditPolicy-->PropertyForComponentItemSemanticEditPolicy
the block has been impacted
Done in the revision 4325
Comment 14 Patrick Tessier CLA 2011-03-17 07:21:31 EDT
OperationEditPart-->OperationForComponentEditPart
OperationCreateCommand-->OperationForComponentCreateCommand
OperationItemSemanticEditPolicy-->OperationForComponentItemSemanticEditPolicy
the block diagram has been impacted
 done in the revision 4326
Comment 15 Patrick Tessier CLA 2011-03-17 08:18:53 EDT
Class2EditPart-->NestedClassForComponentEditPart
Class2CreateCommand-->NestedClassForComponentCreateCommand
Class2ItemSemanticEditPolicy-->NestedClassForComponentItemSemanticEditPolicy
the block definition diagram is also impacted 
done in the revision 4326
Comment 16 Patrick Tessier CLA 2011-03-17 08:41:21 EDT
Property2EditPart--> PropertyForSignalEditPart
Property2CreateCommand--> PropertyForSignalCreateCommand
Property2ItemSemanticEditPolicy-->PropertyForSignalItemSemanticEditPolicy
Block diagram has been impacted
done in the revision 4328
Comment 17 Patrick Tessier CLA 2011-03-17 08:57:46 EDT
Property3EditPart --> PropertyForInterfaceEditPart
Property3CreateCommand-->PropertyForInterfaceCreateCommand
Property3lItemSemanticEditPolicy-->PropertyForInterfaceItemSemanticEditPolicy
block definition has been impacted
a modif has been done in requirement in order to compile
done in the revision 4329
Comment 18 Patrick Tessier CLA 2011-03-17 09:20:38 EDT
Operation2EditPart--> OperationForInterfaceEditpart
Operation2CreateCommand--> OperationForInterfaceCreateCommand
Operation2lItemSemanticEditPolicy--> OperationForInterfaceItemSemanticEditPolicy
block definition diagram has been impacted
Done in the revision 4330
Comment 19 Patrick Tessier CLA 2011-03-17 09:30:37 EDT
Class3EditPart->NestedClassForInterfaceEditPart
Class3CreateCommand--> NestedClassForInterfaceCreateCommand
Class3lItemSemanticEditPolicy--> NestedClassForInterfaceItemSemanticEditPolicy
block diagram has been impacted
Done in the revision 4331
Comment 20 Patrick Tessier CLA 2011-03-17 09:56:42 EDT
ComponentAttributeCompartment2EditPart-->ComponentAttributeCompartmentEditPartCN
ComponentAttributeCompartment2CanonicalEditPolicy-->ComponentAttributeCompartmentCanonicalEditPolicyCN
ComponentAttributeCompartment2ItemSemanticEditPolicy-->ComponentAttributeCompartmentItemSemanticEditPolicyCN

ComponentOperationCompartment2EditPart-->ComponentOperationCompartmentEditPartCN
ComponentOperationCompartment2CanonicalEditPolicy-->ComponentOperationCompartmentCanonicalEditPolicyCN
ComponentOperationCompartment2ItemSemanticEditPolicy-->ComponentOperationCompartmentItemSemanticEditPolicyCN

ComponentNestedClassifierCompartment2EditPart-->ComponentNestedClassifierCompartmentEditPartCN
ComponentNestedClassifierCompartment2CanonicalEditPolicy-->ComponentNestedClassifierCompartmentCanonicalEditPolicyCN
ComponentNestedClassifierCompartment2ItemSemanticEditPolicy-->ComponentNestedClassifierCompartmentItemSemanticEditPolicyCN

Done in the revision 4332
Comment 21 Patrick Tessier CLA 2011-03-17 10:34:43 EDT
SignalAttributeCompartment2EditPart--> SignalAttributeCompartmentEditPartCN
SignalAttributeCompartment2CanonicalEditPolicy-->SignalAttributeCompartmentCanonicalEditPolicyCN
SignalAttributeCompartment2ItemSemanticEditPolicy-->SignalAttributeCompartmentItemSemanticEditPolicyCN
Done in the revision 4333
Comment 22 Patrick Tessier CLA 2011-03-17 10:52:27 EDT
InterfaceAttributeCompartment2EditPart-->InterfaceAttributeCompartmentEditPartCN
InterfaceAttributeCompartment2CanonicalEditPolicy-->InterfaceAttributeCompartmentCanonicalEditPolicyCN
InterfaceAttributeCompartment2ItemSemanticEditPolicy-->InterfaceAttributeCompartmentItemSemanticEditPolicyCN


InterfaceOperationCompartment2EditPart-->InterfaceOperationCompartmentEditPartCN
InterfaceOperationCompartment2CanonicalEditPolicy-->InterfaceOperationCompartmentCanonicalEditPolicyCN
InterfaceOperationCompartment2ItemSemanticEditPolicy-->InterfaceOperationCompartmentItemSemanticEditPolicyCN

InterfaceNestedClassifierCompartment2EditPart-->InterfaceNestedClassifierCompartmentEditPartCN
InterfaceNestedClassifierCompartment2CanonicalEditPolicy-->InterfaceNestedClassifierCompartmentCanonicalEditPolicyCN
InterfaceNestedClassifierCompartment2ItemSemanticEditPolicy-->InterfaceNestedClassifierCompartmentItemSemanticEditPolicyCN
Done in the revision 4334
Comment 23 Patrick Tessier CLA 2011-03-17 11:01:42 EDT
ModelPackageableElementCompartment2EditPart-->ModelPackageableElementCompartmentEditPartCN
ModelPackageableElementCompartment2CanonicalEditPolicy-->ModelPackageableElementCompartmentCanonicalEditPolicyCN
ModelPackageableElementCompartment2ItemSemanticEditPolicy-->ModelPackageableElementCompartmentItemSemanticEditPolicyCN
Block diagram has been impacted 
done in the revision 4335
Comment 24 Patrick Tessier CLA 2011-03-17 11:11:56 EDT
EnumerationEnumerationLiteralCompartment2EditPart-->EnumerationEnumerationLiteralCompartmentEditPartCN
EnumerationEnumerationLiteralCompartment2CanonicalEditPolicy-->EnumerationEnumerationLiteralCompartmentCanonicalEditPolicyCN
EnumerationEnumerationLiteralCompartment2ItemSemanticEditPolicy-->EnumerationEnumerationLiteralCompartmentItemSemanticEditPolicyCN
Done in the revision 4336
Comment 25 Patrick Tessier CLA 2011-03-17 11:33:29 EDT
PackagePackageableElementCompartmentEditPart --> PackagePackageableElementCompartmentEditPartCN
PackagePackageableElementCompartmentCanonicalEditPolicy--> PackagePackageableElementCompartmentCanonicalEditPolicyCN
PackagePackageableElementCompartmentItemSemanticEditPolicy-->PackagePackageableElementCompartmentItemSemanticEditPolicyCN

requirement diagram and block diagram has been impacted.
Done in the revision 4339
Comment 26 Patrick Tessier CLA 2011-03-17 11:38:45 EDT
I have done a bad rename
PropertyForClassCNEditPart-->PropertyForClassEditPart
PropertyForClassCNItemSemanticEditPolicy->PropertyForClassItemSemanticEditPolicy
PropertyForClassCNCreateCommand-->PropertyForClassCreateCommand

fixed in the revision 4340
Comment 27 Patrick Tessier CLA 2011-03-18 05:28:22 EDT
ClassOperationCompartmentEditPart-->ClassOperationCompartmentEditPartCN
ClassOperationCompartmentCanonicalEditPolicy-->ClassOperationCompartmentCanonicalEditPolicyCN
ClassOperationCompartmentItemSemanticEditPolicy-->ClassOperationCompartmentItemSemanticEditPolicyCN

Operation3EditPart-->OperationForClassEditPart
Operation3CreateCommand-->OperationForCla	ssCreateCommand
Operation3CanonicalEditPolicy-->OperationForClassCreateCanonicalEditPolicy
Operation3ItemSemanticEditPolicy-->OperationForClassItemSemanticEditPolicy

ClassNestedClassifierCompartmentEditPart-->ClassNestedClassifierCompartmentEditPartCN
ClassNestedClassifierCompartmentCanonicalEditPolicy->ClassNestedClassifierCompartmentCanonicalEditPolicyCN
ClassNestedClassifierCompartmentItemSemanticEditPolicy-->ClassNestedClassifierCompartmentItemSemanticEditPolicyCN

Class5EditPart-->NestedClassForClassEditPart
Class5CreateCommand-->NestedClassForClassCreateCommand
Class5CanonicalEditPolicy-->NestedClassForClassCanonicalEditPolicy
Class5ItemSemanticEditPolicy-->NestedClassForClassItemSemanticEditPolicy
Done in the revision 4342
Comment 28 Patrick Tessier CLA 2011-03-18 06:13:51 EDT
DataTypeAttributeCompartment2EditPart-->DataTypeAttributeCompartmentEditPartCN
DataTypeAttributeCompartment2CanonicalEditPolicy-->DataTypeAttributeCompartmentCanonicalEditPolicyCN
DataTypeAttributeCompartment2ItemSemanticEditPolicy-->DataTypeAttributeCompartmentItemSemanticEditPolicyCN

Property5EditPart--> PropertyforDataTypeEditPart
Property5CreateCommand-->PropertyforDataTypeCreateCommand
Property5CanonicalEditPolicy-->PropertyforDataTypeCanonicalEditPolicy
Property5ItemSemanticEditPolicy-->PropertyforDataTypeItemSemanticEditPolicy


DataTypeOperationCompartment2EditPart-->DataTypeOperationCompartmentEditPartCN
DataTypeOperationCompartment2ItemSemanticEditPolicy-->DataTypeOperationCompartmentItemSemanticEditPolicyCN
DataTypeOperationCompartment2CanonicalEditPolicy-->DataTypeOperationCompartmentCanonicalEditPolicyCN

Operation4EditPart-->OperationForDataTypeEditPart
Operation4CreateCommand-->OperationForDataTypeCreateCommand
Operation4CanonicalEditPolicy-->OperationForDataTypeCanonicalEditPolicy
Operation4ItemSemanticEditPolicy-->OperationForDataTypeItemSemanticEditPolicy

Block diagram has been impacted
Done in the revision 4343
Comment 29 Patrick Tessier CLA 2011-03-18 06:14:37 EDT
DataTypeAttributeCompartment2EditPart-->DataTypeAttributeCompartmentEditPartCN
DataTypeAttributeCompartment2CanonicalEditPolicy-->DataTypeAttributeCompartmentCanonicalEditPolicyCN
DataTypeAttributeCompartment2ItemSemanticEditPolicy-->DataTypeAttributeCompartmentItemSemanticEditPolicyCN

Property5EditPart--> PropertyforDataTypeEditPart
Property5CreateCommand-->PropertyforDataTypeCreateCommand
Property5CanonicalEditPolicy-->PropertyforDataTypeCanonicalEditPolicy
Property5ItemSemanticEditPolicy-->PropertyforDataTypeItemSemanticEditPolicy


DataTypeOperationCompartment2EditPart-->DataTypeOperationCompartmentEditPartCN
DataTypeOperationCompartment2ItemSemanticEditPolicy-->DataTypeOperationCompartmentItemSemanticEditPolicyCN
DataTypeOperationCompartment2CanonicalEditPolicy-->DataTypeOperationCompartmentCanonicalEditPolicyCN

Operation4EditPart-->OperationForDataTypeEditPart
Operation4CreateCommand-->OperationForDataTypeCreateCommand
Operation4CanonicalEditPolicy-->OperationForDataTypeCanonicalEditPolicy
Operation4ItemSemanticEditPolicy-->OperationForDataTypeItemSemanticEditPolicy

Block diagram has been impacted
Done in the revision 4343
Comment 30 Patrick Tessier CLA 2011-03-18 06:28:55 EDT
Comment2EditPart-->CommentEditPartCN
Comment2CreateCommand-->CommentCreateCommandCN
Comment2ItemSemanticEditPolicy-->CommentItemSemanticEditPolicyCN

CommentBody2EditPart-->CommentBodyEditPartCN
block diagram has been impacted
Done in the revision 4344
Comment 31 Patrick Tessier CLA 2011-03-18 06:47:30 EDT
Constraint2EditPart-->ConstraintEditPartCN
Constraint2CreateCommand-->ConstraintCreateCommandCN
Constraint2ItemSemanticEditPolicy-->ConstraintItemSemanticEditPolicyCN

ConstraintName2EditPart-->ConstraintNameEditPartCN
block diagram has been impacted 4345
Comment 32 Patrick Tessier CLA 2011-03-18 06:50:28 EDT
AssociationClassName2EditPart-->AssociationClassNameEditPart

Done in the revision 4346
Comment 33 Patrick Tessier CLA 2011-03-18 07:01:25 EDT
ModelPackageableElementCompartmentEditPart-->ModelPackageableElementCompartmentEditPartTN
ModelPackageableElementCompartmentCanonicalEditPolicy-->ModelPackageableElementCompartmentCanonicalEditPolicyTN
ModelPackageableElementCompartmentItemSemanticEditPolicy-->ModelPackageableElementCompartmentItemSemanticEditPolicyTN
block diagram has been impacted
Done in the revision 4347
Comment 34 Patrick Tessier CLA 2011-03-18 07:12:21 EDT
PackagePackageableElementCompartment2EditPart-->PackagePackageableElementCompartmentEditPart
PackagePackageableElementCompartment2CanonicalEditPolicy-->PackagePackageableElementCompartmentCanonicalEditPolicy
PackagePackageableElementCompartment2ItemSemanticEditPolicy-->PackagePackageableElementCompartmentItemSemanticEditPolicy
block, requirement and package diagram has been impacted
done in the revision 4324
Comment 35 Patrick Tessier CLA 2011-03-18 07:28:11 EDT
ClassAttributeCompartment2EditPart-->ClassAttributeCompartmentEditPart
ClassAttributeCompartment2CanonicalEditPolicy-->ClassAttributeCompartmentCanonicalEditPolicy
ClassAttributeCompartment2ItemSemanticEditPolicy-->ClassAttributeCompartmentItemSemanticEditPolicy

ClassOperationCompartment2EditPart-->ClassOperationCompartmentEditPart
ClassOperationCompartment2ItemSemanticEditPolicy-->ClassOperationCompartmentItemSemanticEditPolicy
ClassOperationCompartment2CanonicalEditPolicy-->ClassOperationCompartmentCanonicalEditPolicy

ClassNestedClassifierCompartment2EditPart-->ClassNestedClassifierCompartmentEditPart
ClassNestedClassifierCompartment2CanonicalEditPolicy-->ClassNestedClassifierCompartmentCanonicalEditPolicy
ClassNestedClassifierCompartment2ItemSemanticEditPolicy-->ClassNestedClassifierCompartmentItemSemanticEditPolicy

block definition has been impacted
done in the revision 4350
Comment 36 Patrick Tessier CLA 2011-03-18 07:46:21 EDT
AssociationName2EditPart-->AssociationNameEditPart
AssociationName3EditPart-->AssociationTargetNameEditPart
AssociationName5EditPart-->AssociationSourceNameEditPart
AssociationMultiplictySourceEditPart-->AssociationMultiplicitySourceEditPart
AssociationMultiplictyTargetEditPart-->AssociationMultiplicityTargetEditPart

done in the revision 4324
Comment 37 Patrick Tessier CLA 2011-03-18 08:52:18 EDT
SubstitutionName2EditPart-->SubstitutionNameEditPart
RealizationName2EditPart-->RealizationNameEditPart
done in the revision 4352
Comment 38 Patrick Tessier CLA 2011-03-18 09:48:35 EDT
I have reorder elements in the gmfgen
1.  Child label
2.  AffixedNode
3.  Child node
4.  Top node
5.  Compartment child node
6.  Compartment top node
7.  Links
Done  in the version 4354
Comment 39 Vincent Lorenzo CLA 2011-04-19 12:38:37 EDT
I reopen the bug, because some classes did have been refactored  :
InterfaceRealizationName2EditPart
InterfaceRealizationName2ItemSemanticEditPolicy
Comment 40 Patrick Tessier CLA 2013-02-08 09:54:22 EST
done in the revision 10097 in the branch thanks to Nizar GUEDIDI.
see bug 345889 for the patch
Comment 41 Patrick Tessier CLA 2013-02-27 05:50:07 EST
Created attachment 227656 [details]
patch

a. I, Nizar GUEDIDI, wrote 100% of the code I've provided.
b. I have the right to contribute the code to Eclipse.
c. I contribute the content under the EPL.
d. This contribution contains no Cryptography features.
Comment 42 Patrick Tessier CLA 2013-02-27 05:51:07 EST
done for the head revision 10277