Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339959

Summary:

CMP "Bean supertype" dropbox should not process the events of blank selection

Product:

[WebTools] WTP EJB Tools

Reporter:

Diego Sahagun <diegosr>

Component:

jst.ejb

Assignee:

Carl Anderson <ccc>

Status:

RESOLVED INVALID

QA Contact:

Kaloyan Raev <kaloyan>

Severity:

normal

Priority:

CC:

ccc, david_williams, konstantin

Version:

3.2.2

Target Milestone:

3.2.5

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Ignore blank dropbox selection	none

Description Diego Sahagun

2011-03-14 19:43:50 EDT

Build Identifier: 3.6.2.r362_v20110210

Even invalid selection of a bean supertype is processed, it whould be ignored since that blank choice means "no bean supertype"

Reproducible: Always

Steps to Reproduce:
1. Create an EJB 2.1 project
2. Open new Bean 1.x - 2.x wizard
3. Enter a bean name, select type CMP and click next
4. Remove the default key field (Under CMP attributes:)
5. Select the blank option in the Bean supertype dropbox

The default key is added again, this means that the CMP wizard is acting like a valid supertype bean was selected

Comment 1 Diego Sahagun

2011-03-14 19:45:17 EDT

Created attachment 191177 [details]
Ignore blank dropbox selection

Comment 2 Konstantin Komissarchik

2011-03-14 20:04:18 EDT

Please review the patch in the context of EJB usecase correctness. If appropriate, forward to common for evaluation of appropriatness of framework changes.

Comment 3 Konstantin Komissarchik

2011-03-14 20:05:20 EDT

If I had to guess, the proposed patch is inappropriate generalization of potential EJB scenario into framework code and is likely to break something.

Comment 4 Carl Anderson

2011-03-14 21:08:37 EDT

Asking Dimitar to review the patch, since Kaloyan is unavailable.

Comment 5 Carl Anderson

2011-03-14 21:09:53 EDT

This should be targeted at WTP 3.2.4, but there is no such target in the WTP EJB Tools component yet.

Comment 6 Carl Anderson

2011-03-17 22:55:57 EDT

Comment on attachment 191177 [details]
Ignore blank dropbox selection

I reviewed this patch with Diego.  It breaks functionality.  I am marking it as obsolete.

Comment 7 David Williams

2011-05-12 11:56:20 EDT

I've added additional targets, and am assuming this should move to "3.2.5". 

Just trying to get off the "targeted in the past" list. 

Please correct target or status if my guesses were wrong.

Comment 8 Diego Sahagun

2011-07-27 10:59:33 EDT

The approach I took to determine that there was a defect was not correct, resolving bugzilla as invalid.