Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339930

Summary:	Anticipate UI freeze : MoDisco project & externalize Strings
Product:	[Modeling] MoDisco	Reporter:	Fabien Giquel <fabien.giquel>
Component:	Main	Assignee:	Nicolas Bros <nicolas.bros>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P1	CC:	hugo.bruneliere, modisco.web-inbox, nicolas.bros
Version:	0.9.0	Flags:	nicolas.bros: indigo+
Target Milestone:	0.9.0 M6
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Fabien Giquel

2011-03-14 13:49:35 EDT

Two problems :

- There is a large amount of Strings in MoDisco code which are neither externalized nor annotated with //$NON-NLS-1$ (cf "Source->Externalize String"). I

- There are also problems on several recent projects with "PDE->externalize" (new discoverers such as jee.jsp.discoverer.ui) such as "Eclipse Modeling Project" and things like that.

I open a transverse bug for coming soon M6, rather than reopen each dedicated bugzilla (Java discoverers rewriting ...).


About code non externalized strings, there are a lot of them but it seems it always need just "//$NON-NLS-1$" annotations.
Priority must be given i think to new projects (org.eclipse.modisco.XXX) rather than old ones (org.eclipse.gmt.modisco.XXX).

Comment 1 Nicolas Bros

2011-03-15 10:12:09 EDT

Fixed in revisions 4122, 4123, 4126 & 4127.

There are no NLS warnings left in MoDisco plug-ins, but the "Source > Externalize Strings..." wizard still shows many externalizable strings in generated code.
This is because the wizard doesn't look at @SuppressWarning's nor project settings.

Comment 2 Fabien Giquel

2011-03-15 10:30:18 EDT

ok for "Source->Externalize String" strings.

However there are still unexternalized Strings with "PDE->Externalize String". I see them in 4 projects :

- oem.infra.disco.ui.tests
- oem.java.disco.cdo.tests
- oem.workflow.core
- oem.xml.disco.tests.

I reopen the bug.

Comment 3 Fabien Giquel

2011-03-15 10:38:10 EDT

For oem.workflow.core it is ok in fact.

Comment 4 Fabien Giquel

2011-03-15 11:21:10 EDT

discussed with Gregoire : it will be better to externalize "bundle-name/vendor-name" for tests plugins in order to have homogeneous disply in "Installation Details".

Comment 5 Nicolas Bros

2011-03-16 06:05:27 EDT

In all MoDisco plug-ins:
- I externalized Bundle-Name and Bundle-Vendor
- I added the " (Incubation)" suffix in the Bundle-Name of plug-ins that were missing it
- I added the "MoDisco " prefix in the Bundle-Name of plug-ins that were missing it
- I replaced plugin.properties by the new OSGI-INF/l10n/bundle.properties in a few usecase plug-ins that were mixing both the old and new systems (which would lead to missing strings at runtime)
- I added some missing copyrights in bundle.properties
- I replaced OSGI-INF/l10n/bundle.properties by OSGI-INF/ in bin.includes so as to avoid a warning by PDE (Bug 340124).

Committed in revision 4138.

Comment 6 Hugo Bruneliere

2011-08-18 07:58:38 EDT

Upgrades done.