Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339918

Summary: Metamodel update to be able to have facet columns and to be able to have a local customization
Product: z_Archived Reporter: Gregoire Dupe <gdupe>
Component: EMF-FacetAssignee: Gregoire Dupe <gdupe>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: emft.facet-inbox
Version: unspecifiedFlags: gdupe: indigo+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch for Bug 339918 Implementation gdupe: iplog+

Description Gregoire Dupe CLA 2011-03-14 12:24:20 EDT
Hi,

We need to have
 - facet columns in the table ;
 - a local customization in the table instance;
 - a default local customization in the table configurations.

Regards,
Gregoire
Comment 1 Gregoire Dupe CLA 2011-03-14 12:44:15 EDT
I've committed the following modifications:
 - add of the classes FacetAttributColumn, FacetReferanceColumn, FacetFeatureColumn.
 - replace of the operation FeatureColumn::getFeature() by the derived reference FeatureColumn::feature
 - add of the references TableInstance::localCustomization
 - add of the reference TableConfiguration::defaultLocalCustomization

Committed revision 395.

We still have to implement:
org.eclipse.emf.facet.widgets.nattable.instance.tableinstance.impl.AttributeColumnImpl.basicGetFeature()
org.eclipse.emf.facet.widgets.nattable.instance.tableinstance.impl.AttributeColumnImpl.basicGetFeature()
org.eclipse.emf.facet.widgets.nattable.instance.tableinstance.impl.FacetFeatureColumnImpl.basicGetFeature()
org.eclipse.emf.facet.widgets.nattable.instance.tableinstance.impl.FacetFeatureColumnImpl.basicGetFacetFeature()
org.eclipse.emf.facet.widgets.nattable.instance.tableinstance.impl.FacetFeatureColumnImpl.setFacetFeature(FacetStructuralFeature)
org.eclipse.emf.facet.widgets.nattable.instance.tableinstance.impl.FacetReferenceColumnImpl.basicGetFeature()
org.eclipse.emf.facet.widgets.nattable.instance.tableinstance.impl.ReferenceColumnImpl.basicGetFeature()

Regards,
Gregoire Dupe
Comment 2 Nicolas Guyomar CLA 2011-03-17 05:22:35 EDT
Created attachment 191384 [details]
Patch for Bug 339918 Implementation

Hi,

Please find attached in a patch the required implementation.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar
Comment 3 Gregoire Dupe CLA 2011-03-17 09:07:48 EDT
Comment on attachment 191384 [details]
Patch for Bug 339918 Implementation

Here are a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 427.
Comment 4 Gregoire Dupe CLA 2011-03-17 09:09:56 EDT
This bug can be marked has fixed.
Comment 5 Gregoire Dupe CLA 2011-06-07 12:47:23 EDT
This bug can be closed.