Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339855

Summary:

ModelCellEditor class should not be exposed

Product:

z_Archived

Reporter:

Nicolas Guyomar <nicolas.guyomar>

Component:

EMF-Facet

Assignee:

Nicolas Bros <nicolas.bros>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

emft.facet-inbox, gdupe, nicolas.bros

Version:

unspecified

Flags:

nicolas.bros: indigo+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch	nicolas.bros: iplog+

Description Nicolas Guyomar

2011-03-14 05:58:19 EDT

Hi,

As part of the EMF Facet API clean, we should not expose the class ModelCellEditor in plug-in org.eclipse.emf.facet.widgets.celleditors

Regards,
Nicolas Guyomar

Comment 1 Nicolas Bros

2011-03-14 06:29:08 EDT

Created attachment 191097 [details]
patch

Comment 2 Nicolas Bros

2011-03-14 06:59:38 EDT

Committed in revision 385.

Comment 3 Nicolas Bros

2011-03-14 07:37:16 EDT

What the patch does:

In ICellEditorsRegistry the method getCellEditorFor(EClassifier type, final boolean many) returned an instance of ModelCellEditor, which was not meant to be API. So, I refactored it into two new methods: getCellEditorFor which returns an IModelCellEditor (which is API) and getNaryCellEditorFor that returns a INaryFeatureCellEditor (which is API too).

As well, I replaced the 2nd override of getCellEditorFor that takes a list of preferred cell editors by two new methods in the same way.

Now, CellEditorsRegistry implements the new version of the interface, but still exposes the old API for internal use in EMF Facet through 2 new getCellEditorWrapperFor methods.

The rest of the changes are to adapt parts of EMF Facet to this new API.

Comment 4 Gregoire Dupe

2011-06-07 12:14:13 EDT

This bug can be closed.