| Summary: | Cannot restart eclipse after m2e installation | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Igor Fedorenko <igor> |
| Component: | m2e | Assignee: | Paul Tatavu <vladt> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | pascal, vladt |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
|
Description
Igor Fedorenko
I have tried the following m2e versions + eclipse classic 3.7M5: 0.13.0.201103111502 0.13.0.201103121705 0.13.0.201103132105 0.13.0.201103141010 and I could not reproduce the problem. I also tried m2e 0.13.0.201103141010 + eclipse classic 3.6.1 and 3.6.2 and could not reproduce it either. Cannot reproduce I just had this problem on a different system (macosx this time) and I simply wanted to start Eclipse this time, i.e. no prio installation before the failure.
From looking at DataArea.assertLocationInitialized and LogPlugin.configureLogback, here is what I believe happens
After the user select workspace location both o.e.m2e.logback.configuration and o.e.resources bundles attempt to access org.eclipse.core.internal.runtime.Activator.getConfigurationLocation() from two separate threads. Implementation of Activator.getConfigurationLocation (below) is not properly synchronized, so one of the two threads gets null reference. o.e.m2e.logback.configuration handles this case gracefully, but o.e.resources fails
public Location getConfigurationLocation() {
if (configLocationTracker == null) {
Filter filter = null;
try {
filter = bundleContext.createFilter(Location.CONFIGURATION_FILTER);
} catch (InvalidSyntaxException e) {
// should not happen
}
configLocationTracker = new ServiceTracker(bundleContext, filter, null);
configLocationTracker.open();
}
return (Location) configLocationTracker.getService();
}
Changed the LogPlugin initialization to wait for the org.eclipse.core.resources plugin to be active. http://git.eclipse.org/c/m2e/m2e-core.git/commit/?id=07867ddc215159d12b46b5e9bbf480b49e961bec |