Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339818

Summary:	Should install our custom build tools with p2 director, instead of jar copy
Product:	[WebTools] WTP Releng	Reporter:	David Williams <david_williams>
Component:	releng	Assignee:	David Williams <david_williams>
Status:	RESOLVED FIXED	QA Contact:	David Williams <david_williams>
Severity:	normal
Priority:	P3
Version:	3.10
Target Milestone:	3.10.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description David Williams

2011-03-13 01:45:27 EST

Currently we install out wtp custom ant tasks into pde base builder just via file copy. We should, instead, use p2 and install from a repository. It'd be more reliable and easier to manage. (Still need to use exact version, though, for most cases, so builds can be reproducible, but, when experimenting with a temp branch, could just use "latest" so fixes/improvements are easier to iterate.

Comment 1 David Williams

2011-03-14 02:31:22 EDT

FYI, what I've learned so far, is that p2 won't install our tools into base builder ... I'm not sure the base builder is created with p2 (e.g. it has no "features" in it, only plugins ... the 'launcher' jar is renamed to not have a version, etc. 

Hence, I think to do this we'd have to stop using the base builder. Luckily, there is no reason for us to, any longer. We no longer use any of the "custom" tools in base builder ... but, provide our own versions. (This was actually done a while back, a year or two ago, because a couple of times, a small change they'd make to their tools would break us). 

So, in addition to using p2, instead of getting base builder from cvs, we'd simply get a version of Eclipse SDK to use as our builder. In theory, we could get platform, then add a pde and jdt, so we could, to some extent, control exactly which version of each piece we were using ... but, I'd hope we'd never need to.

Comment 2 David Williams

2011-03-25 01:06:36 EDT

I've moved build to no longer use the platform's "basebuilder", we can now just use what ever version of Eclipse SDK we'd like. Eventually may want to install Platform, JDT compiler, and PDE all separately, since in theory we could use any version of Platform and PDE Build without changing our bits, and just leave the compiler constant when necessary. 

This greatly simplifies some processes and properties, since the "eclipse builder" is installed like any other "prereq", but simply in a different location where it can then be used to run the build. So the eclipse builder is now specified in dependencies.properties, instead of build.cfg. 

As part of this cleanup, also could do away with separate 'indigo' and 'indigo4' dependency files ... just use one, since only difference is now "eclipse" prereq versus e4x prereq, so we can just include both in one file, and then use which ever we'd like.