Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339810

Summary: Right click selections on folders and files in navigator give irrelevant options
Product: [ECD] Orion Reporter: Paul Beusterien <paul.beusterien>
Component: ClientAssignee: Project Inbox <e4.orion-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: bokowski, simon_kaegi, susan
Version: 0.2   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description Paul Beusterien CLA 2011-03-12 20:36:18 EST
Right click gives the default browser context menu options. These are not very relevant for a developer.

The following line should be added to explorer-table.js

tableRow.setAttribute("oncontextmenu", "setupFileContextMenu(); return false;");

I'm willing to work on the setupFileContextMenu implementation of creating a menu with the appropriate commands, but should probably first sync with someone who knows more about the overall Orion UI strategy than me.
Comment 1 Boris Bokowski CLA 2011-03-13 10:36:28 EDT
We haven't added a context menu yet because:
- it would hide the "open link in new tab/window, view source" etc. native browser menu
- this menu is important during demos, in order to show that links are indeed regular links
- it would not work on touch devices
- we have been burnt by overly long context menus in desktop Eclipse
- we're not sure if users would even expect a context menu in a web app.
Comment 2 Paul Beusterien CLA 2011-03-13 13:03:15 EDT
@Boris Thanks for the quick response.

- it would hide the "open link in new tab/window, view source" etc. native
browser menu

I think open link in new tab should be the default click action. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=339775.  Most of the other options are not relevant for actions on a file in a development environment.

- this menu is important during demos, in order to show that links are indeed
regular links

Links could be shown by directly loading a URL

- it would not work on touch devices

Good point, but are touch devices planned to be supported in early releases? Perhaps a different gesture would work on touch devices? Pinch? 

- we have been burnt by overly long context menus in desktop Eclipse

Replacing long context menus with bad context menus doesn't seem like the right approach. Also, in my opinion, excessive clutter is an even worse Eclipse desktop problem. Avoiding the context menu is causing more clutter in Orion.

- we're not sure if users would even expect a context menu in a web app.

Perhaps this leads to a priority question? - Which is a higher priority for Orion? Be a web app? Or - Be a great development environment for web developers?

Besides, I'm not sure that managing the context menu makes an app less of a web app. It's common practice for web apps to override browsers' default events to make them more relevant for the app.
Comment 3 Simon Kaegi CLA 2011-06-20 22:35:32 EDT
At least for now we're going to try to stick with the everything is a link metaphor and avoiding overriding link context menus.