Bugzilla – Full Text Bug Listing
| Summary: | fill empty context from stack trace when task is activated | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | David Green <greensopinion> | ||||||||
| Component: | Mylyn | Assignee: | David Green <greensopinion> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | mik.kersten, shawn.minto, steffen.pingel | ||||||||
| Version: | unspecified | Keywords: | contributed, noteworthy | ||||||||
| Target Milestone: | 3.6 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 326245, 348348 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
David Green
Created attachment 191036 [details]
patch that implements the described function
patch implements the described functionality. Adds a new extension point, and a concrete implementation for Java stack traces. Please consider as an inclusion to Mylyn 3.6
Created attachment 191037 [details]
mylyn/context/zip
Thanks. We'll need to clarify a CQ is needed here since the contribution exceeds the 250 line limit. Note that I didn't externalize any of the strings. This was intentional, to make refactoring easier. Once the patch is looking good, we can externalize strings too. what's needed to move this forward? I have to file a CQ. Can you confirm that you have authored the code, have a right to contribute the content to Eclipse and that you contribute the content under EPL? This is my confirmation that I, David Green: * Authored the code. * Have a right to contribute the content to Eclipse. * Contribute the content under EPL. *** Bug 108067 has been marked as a duplicate of this bug. *** Thanks David. I have filed CQ 5097 to move this forward. Looks like the CQ was approved! 5097: feature enhancement to fill task context from stack trace https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5097 What's the next step? Thanks for the great patch, David! I have applied it to head. I made a few modifications: * The extension point is o.e.m.context.core now since there is now API dependency on the UI. * I remove the coupling to the Tasks from the API. The input is now passed as an IAdaptable to allow easier reuse in other contexts, e.g. for generating contexts based on build failures. * Elements from the java and javax namespace are filtered when generating contexts. We may want to consider adding additional filters but that already helped to make contexts more relevant. * I ran into an exception when no strategies where registered which I fixed by adding a null check: java.lang.NullPointerException at org.eclipse.mylyn.internal.context.ui.ContextPopulationStrategy$1.run(ContextPopulationStrategy.java:88) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) Committed changes for o.e.m.context.ui to head which got accidentally committed to e_4_0_m_3_x initially. Feature should appear in next weekly build. Created attachment 197037 [details]
screenshot
Thanks Steffen! |