Bugzilla – Full Text Bug Listing
| Summary: | Clicking a file in the Navigator wipes out Navigator view | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Paul Beusterien <paul.beusterien> |
| Component: | Client | Assignee: | Project Inbox <orion.client-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | pradyutksarma, simon_kaegi, susan |
| Version: | 0.2 | ||
| Target Milestone: | 0.5 | ||
| Hardware: | PC | ||
| OS: | Mac OS X | ||
| Whiteboard: | |||
This was actually intentional. The general approach in Orion is to let the browser/user decide on page management decisions like this, rather than us making the decision for them. Some people like to "go into" a link on the same page, others like to open new tabs. Even within the small group of Orion committers we are quite mixed on this. Users can control this via Ctrl+Click vs Click in most browsers. "Clicking a link wipes out the page" is standard/expected web behaviour, and they can always hit "Back" to get back to the navigator. This will always be a subjective thing, so if we want to "fix" it, I think it will involve a user setting. Hi John, I guess a large section of users would want the Navigator to remain with them during the time they browse through the contents of a file. @Susan, But there's another point even if you provide a user setting to control this behavior. This will mean you will now have a Favourites tree, then the Navigator tree and then the editor together. I don't know whether the favourites tree and the Navigator would look GOOD together. What would be more helpful if you could also provide a feature by which I would be able to dock the Favourites view somewhere below the Navigator and the editor. Maybe this behavior could be applied to any view that is created....similar to the way eclipse views work i.e. I can arrange the views the way I want in my workarea. Probably you guys have already thought about it ;) Thanks and Best Regards, Pradyut. (In reply to comment #1) > This was actually intentional. The general approach in Orion is to let the > browser/user decide on page management decisions like this, rather than us > making the decision for them. Some people like to "go into" a link on the same > page, others like to open new tabs. Even within the small group of Orion > committers we are quite mixed on this. Users can control this via Ctrl+Click vs > Click in most browsers. "Clicking a link wipes out the page" is > standard/expected web behaviour, and they can always hit "Back" to get back to > the navigator. (In reply to comment #3) >What would be more > helpful if you could also provide a feature by which I would be able to dock > the Favourites view somewhere below the Navigator and the editor. Maybe this > behavior could be applied to any view that is created....similar to the way > eclipse views work i.e. I can arrange the views the way I want in my workarea. > Probably you guys have already thought about it ;) Hi, Pradyut. That is indeed something we've thought about, it just didn't make the cut for our first release, because it's not critical for our self hosting needs. Please cc: yourself on bug 339566 and you can follow progress there. Thanks Susan. Waiting for the feature ;o) (In reply to comment #4) > (In reply to comment #3) > >What would be more > > helpful if you could also provide a feature by which I would be able to dock > > the Favourites view somewhere below the Navigator and the editor. Maybe this > > behavior could be applied to any view that is created....similar to the way > > eclipse views work i.e. I can arrange the views the way I want in my workarea. > > Probably you guys have already thought about it ;) > > Hi, Pradyut. That is indeed something we've thought about, it just didn't make > the cut for our first release, because it's not critical for our self hosting > needs. Please cc: yourself on bug 339566 and you can follow progress there. I'm going to mark this fixed because you can now set the "open link in new tab" preference to cause clicking in the navigator to open an editor in a new tab rather than in place. I think that was the original complaint. There is also discussion in this bug for getting to favorites from other places, which we now do via the "open file" popup. The "I want a navigator in my editor" is still an open bug (bug 389643). |
This change causes the editor to open in another tab: org.eclipse.orion.client/bundles/org.eclipse.orion.client.core/static/js/explorer-table.js 263c263 < link = dojo.create("a", {className: "navlinkonpage", href: "#" + item.ChildrenLocation}, div, "last"); --- > link = dojo.create("a", {className: "navlinkonpage", href: "#" + item.ChildrenLocation, target: "_blank"}, div, "last"); 291c291 < link = dojo.create("a", {className: "navlink", href: href}, div, "last"); --- > link = dojo.create("a", {className: "navlink", href: href, target: "_blank"}, div, "last");