Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339768

Summary: [terminal] The Terminal doesn't react to the PageUp key properly
Product: [Tools] Target Management Reporter: Martin Oberhuber <mober.at+eclipse>
Component: TerminalAssignee: Martin Oberhuber <mober.at+eclipse>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: eclipse, mstepanov
Version: 3.2   
Target Milestone: 3.3 M7   
Hardware: PC   
OS: Linux   
URL: https://aptana.lighthouseapp.com/projects/35272/tickets/1045
Whiteboard:
Bug Depends on:    
Bug Blocks: 346969    
Attachments:
Description Flags
Proposed fix
mober.at+eclipse: iplog+
Same patch as "workspace patch" none

Description Martin Oberhuber CLA 2011-03-11 16:51:27 EST 
From https://aptana.lighthouseapp.com/projects/35272/tickets/1045 :

The terminal doesn't react to PageUp. 

A fix is possible in VT100TerminalControl as per Aptana github commit b0f824be1b40aadfada01162dc927c26ced4a453

This bug is kindly asking Aptana to contribute this fix back under EPL.
Comment 1 Max Stepanov CLA 2011-04-06 19:11:26 EDT 
Created attachment 192681 [details]
Proposed fix

The attached patch fixes the issue with Terminal when wrong ESC sequences are being sent for PageUp/Down keys.
Comment 2 Martin Oberhuber CLA 2011-04-06 19:26:21 EDT 
Patch looks good - thanks!

For completeness, could you please add a legal note here on bugzilla declaring that you developed the patch yourself, and you have the right to contribute under the EPL... as per the template here:
http://eclipse.org/tm/development/committer_howto.php#external_contrib

Thanks
Martin
Comment 3 Max Stepanov CLA 2011-04-06 19:32:59 EDT 
I, Max Stepanov, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer Appcelerator, Inc. to make this contribution under the EPL.
Comment 4 Martin Oberhuber CLA 2011-04-07 00:45:34 EDT 
Created attachment 192695 [details]
Same patch as "workspace patch"

I've applied the patch - thanks!

Moving forward, in case you create patches with Eclipse it would help if you could create them with "patch root: Workspace (Multi-project apply patch wizard specific)". This slightly simplifies applying patches since I don't have to pick the project that the patch applies to. In this case it was simple since I knew it applied to Terminal.

If you don't use Eclipse to create the patch that's also fine.
Comment 5 Martin Oberhuber CLA 2011-04-07 00:52:34 EDT 
Committed and released to 3.3m7 > 20110407

You're now in our contributor's hall of fame :)
http://eclipse.org/tm/development/contributors.php
http://www.eclipse.org/projects/ip_log.php?projectid=tools.tm