Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339699

Summary:

Wrong name file in EMF Facet tests

Product:

z_Archived

Reporter:

Nicolas Guyomar <nicolas.guyomar>

Component:

EMF-Facet

Assignee:

Nicolas Bros <nicolas.bros>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

emft.facet-inbox, gdupe, nicolas.bros

Version:

unspecified

Flags:

nicolas.bros: indigo+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch for Bug 339699	nicolas.bros: iplog+
Patch Bug 339699 build project.patch	nicolas.bros: iplog+

Description Nicolas Guyomar

2011-03-11 09:48:06 EST

Hi,

When MoDisco infra layer tests where copied into EMF Facet project, some files referenced in plugin.xml, like query or uiCustom, where not accurately renamed, as well as some folders.

Concerned plug-in are : 

org.eclipse.emf.facet.infra.browser.custom.tests
org.eclipse.emf.facet.infra.query.tests
org.eclipse.emf.facet.infra.facet.tests
org.eclipse.emf.facet.infra.common.core.tests

Regards,
Nicolas Guyomar

Comment 1 Nicolas Guyomar

2011-03-14 09:59:23 EDT

Hi,

Here is a list of the necessary modifications before some corrections could be made

in plug-in org.eclipse.emf.facet.infra.browser.custom.tests: 
- file org.eclipse.gmt.modisco.infra.browser.custom.tests.querySet has to be renamed by org.eclipse.emf.facet.infra.browser.custom.tests.querySet
- file org.eclipse.gmt.modisco.infra.browser.custom.tests.uiCustom has to be renamed by org.eclipse.emf.facet.infra.browser.custom.tests.uiCustom

in plug-in org.eclipse.emf.facet.infra.query.tests
- folder modisco has to be renamed by emffacet
- file modisco.infra.query.tests.01.querySet has to be renamed by emffacet.infra.query.tests.01.querySet
- file modisco.infra.query.tests.02.querySet has to be renamed by emffacet.infra.query.tests.02.querySet
- file modisco.infra.query.tests.03.querySet has to be renamed by emffacet.infra.query.tests.03.querySet

Regards,
Nicolas Guyomar

Comment 2 Nicolas Bros

2011-03-14 10:10:49 EDT

(In reply to comment #1)
I committed the renamings in revision 393.

Comment 3 Nicolas Guyomar

2011-03-14 12:25:26 EDT

Created attachment 191133 [details]
Patch for Bug 339699

Hi,

Thanks Nicolas for the renaming.
I managed to get the tests working on my computer.

Here is a patch with the required modifications.

Could we test that they pass on the nightly build ?

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar

Comment 4 Nicolas Guyomar

2011-03-14 12:46:44 EDT

Created attachment 191147 [details]
Patch Bug 339699 build project.patch

Hi,

Please find attached a new version of plug-in :
- org.eclipse.emf.facet.tests.feature
- org.eclipse.emf.facet.tests
for their integration in the build.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar

Comment 5 Nicolas Bros

2011-03-14 13:07:08 EDT

I commited your patches in revisions 396 & 397.

Comment 6 Gregoire Dupe

2011-06-06 11:46:06 EDT

This bug can be closed.