Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339698

Summary:	[server] We should not keep the state in servlets
Product:	[ECD] Orion	Reporter:	Szymon Brandys <Szymon.Brandys>
Component:	Client	Assignee:	Tomasz Zarna <tomasz.zarna>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.2
Target Milestone:	0.2
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Szymon Brandys

2011-03-11 09:32:49 EST

I noticed that in some places we keep states in servlets or handlers used by servlets. For instance:
GitIndexHandlerV1 has a private Repository db field, which is set by #handleRequest and reuse later. Since our servlets along with handlers are singletons this is a potential threat.

Comment 1 Tomasz Zarna

2011-03-14 07:14:57 EDT

Fixed with 555fd0d6cb28ba9d4dcdadf05ae489455db6b1a2.