Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339639

Summary: [builder] QueuedBuildData#queueURI(URI) should be public
Product: [Modeling] TMF Reporter: Knut Wannheden <knut.wannheden>
Component: XtextAssignee: Project Inbox <tmf.xtext-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: sven.efftinge
Version: 2.0.0Flags: sven.efftinge: indigo+
Target Milestone: M7   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch for QueuedBuildData none

Description Knut Wannheden CLA 2011-03-11 01:25:33 EST 
The method QueuedBuildData#queueURI(URI) is currently declared with package level visibility. I think it should be changed to public to allow subclassing in order to provide custom build ordering algorithms.
Comment 1 Knut Wannheden CLA 2011-03-11 01:25:59 EST 
Created attachment 190956 [details]
patch for QueuedBuildData
Comment 2 Sven Efftinge CLA 2011-03-26 15:06:57 EDT 
*** Bug 339638 has been marked as a duplicate of this bug. ***
Comment 3 Sven Efftinge CLA 2011-03-26 15:09:25 EDT 
marking it 'protected' should be sufficient to allow for subclassing.
Comment 4 Knut Wannheden CLA 2011-03-27 03:36:49 EDT 
Since the method is also called from within the BuildData class I think public would make sense here.
Comment 5 Sven Efftinge CLA 2011-03-29 00:19:27 EDT 
pushed to master
Comment 6 Karsten Thoms CLA 2017-09-19 17:12:32 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 7 Karsten Thoms CLA 2017-09-19 17:24:07 EDT 
Closing all bugs that were set to RESOLVED before Neon.0